Do not log traceback if file has skip_file comment#416
Merged
karthiknadig merged 2 commits intomicrosoft:mainfrom Jul 24, 2024
Merged
Do not log traceback if file has skip_file comment#416karthiknadig merged 2 commits intomicrosoft:mainfrom
skip_file comment#416karthiknadig merged 2 commits intomicrosoft:mainfrom
Conversation
jicruz96
commented
Jul 5, 2024
| except isort.exceptions.FileSkipped: | ||
| log_warning(traceback.format_exc(chain=True)) | ||
| # Ignore file skipped. | ||
| return None |
Contributor
Author
There was a problem hiding this comment.
returning None avoids an uncaught LSP server error:
karthiknadig
approved these changes
Jul 9, 2024
karthiknadig
added
the
bug
bpasero
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #415
Let's assume you have a file with a
# isort: skip_filecomment.Before:
You'd get a nearly illegible traceback:
After: