Remove follow-imports argument which may conflict with projects#90
Merged
karthiknadig merged 1 commit intomicrosoft:mainfrom Jul 18, 2023
Merged
Conversation
mypy prioritises values from configuration on its command line over that provided in configuration files. This means that the value previously provided here could override the settings for a project, cause spurious errors and/or hiding true errors. Removing this default value allows users freedom to configure their projects however they like, without the extension injecting unexpected additional configuration within the IDE context. Tested manually by opening a project which has a `setup.cfg` and changing the `follow_imports` value within that file, then checking the errors reported from `mypy` change accordingly. Fixes microsoft#89
karthiknadig
approved these changes
Jul 17, 2023
karthiknadig
added
the
bug
anthonykim1
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy prioritises values from configuration on its command line over that provided in configuration files. This means that the value previously provided here could override the settings for a project, cause spurious errors and/or hiding true errors.
Removing this default value allows users freedom to configure their projects however they like, without the extension injecting unexpected additional configuration within the IDE context.
Tested manually by opening a project which has a
setup.cfgand changing thefollow_importsvalue within that file, then checking the errors reported frommypychange accordingly.Fixes #89