fix: prevent catastrophic regex backtracking in _extractImagesFromOutput#307447
Merged
justschen merged 2 commits intomicrosoft:mainfrom Apr 2, 2026
Merged
Conversation
justschen
approved these changes
Apr 2, 2026
Collaborator
justschen
left a comment
There was a problem hiding this comment.
thanks for taking a look!
rzhao271
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307431
Problem
_extractImagesFromOutputinRunInTerminalToolfreezes the renderer main thread for 15–20 seconds on large terminal output. The root cause is a two-step pattern:output.replace(/\r?\n/g, '')strips all newlines, producing a single mega-string./(?:[^\s]*[\/\\][^\s]*\.(?:png|jpe?g|gif|webp|bmp))/gihas ambiguity —[^\s]*can consume/and\, overlapping with the[\/\\]separator. On a long string the engine explores an exponential number of split-points, causing O(2ⁿ) backtracking.Profiler evidence: 14/14 renderer-hang samples land on
RegExpStringIterator.nextinside_extractImagesFromOutput.Fix
[^\s]*to[^\s/\\]*— each atom can no longer consume path separators, making the[/\\]tokens unambiguous and eliminating backtracking entirely.