Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: fix explanation of darwin auto-quit prevention #394
Conversation
| // Quit when all windows are closed. | ||
| // Quit when all windows are closed, except on macOS. There, it's common | ||
| // for applications and their menu bar to stay active until the user quits | ||
| // explicitly with Cmd + Q. |
codebytere
Jun 11, 2020
Member
i'm not sure what's changed here? this copy was just moved but doesn't look to have been changed at all
i'm not sure what's changed here? this copy was just moved but doesn't look to have been changed at all
malept
Jun 11, 2020
Member
It's basically clarification via consolidating the comments. See electron/electron#24003 for context.
It's basically clarification via consolidating the comments. See electron/electron#24003 for context.
|
This is consistent with electron/electron#24003 so |
codebytere
pushed a commit
to electron/electron-quick-start-typescript
that referenced
this pull request
Jun 16, 2020
…tart' (#38) 1. updated dev dependencies 2. Content-Security-Policy added f844bb7 : Ref - electron/electron-quick-start@0ed07b8 & electron/electron-quick-start#334 3. no need to hold on to mainWindow reference 478f1be : Ref -electron/electron#21957 & electron/electron-quick-start#357 4. don't listen to 'activate' until ready 3e5cfff : fixes electron/electron#23476 & Ref: electron/electron-quick-start#382 5. fix explanation of darwin auto-quit prevention 7679354 : Ref : electron/electron#24003 & electron/electron-quick-start#394 6. docs: update stale comment - renderer has no access to Node 8e4701c : Ref: electron/electron-quick-start@6788309 & electron/electron-quick-start#308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I fixed the comment above the auto-quit prevention for macOS.
Before it suggested the code quits the app, now it says the code prevents the app from quitting.
Note: This same pull request was on Electron #24003. I added it here too for consistency.