If formatter not installed we do not always offer installation

[MikhailArkhipov]

Environment data

VS Code version: 1.19
Python Extension version: 0.9
Python Version: 3.6
OS and version: Windows 10

autopep8 is missing and I get

Formatting with autopep8 failed.
Error: C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe: 
No module named autopep8

Actual error does contain No module named but in

const isModuleNoInstalledError = errorObj.code === 1 && error.message.indexOf('No module named') >= 0;

code is null

Also, output to the status bar is truncated and does not look like an error message

Also, it looks like in

            const isInstalled = await installer.isInstalled(this.product, resource);
            if (isInstalled) {

should be !isInstalled

[MikhailArkhipov]

Attempt to install yields

PermissionError: [WinError 5] 
Access is denied: 
'C:\\Program Files (x86)\\Microsoft Visual Studio\\Shared\\Python36_64\\Lib\\site-packages\\yapf

[MikhailArkhipov]

Got this fixed and implemented elevated install

[brettcannon]

For installing globally you should use python3 -m pip install --user autopep8

[MikhailArkhipov]

Don't --user means 'per user'? We can do per user (which may or may not be desirable). My implementation uses standard setup if target folder is writable and attempts elevated if not.

[brettcannon]

Yes, --user means per user account on the machine. I really do not want to promote elevated, global installs anywhere as that's considered bad practice in the Python community. I also don't like global installs even if they don't require elevation since you can't control those installs as well and you typically don't want to force packages on all users of a machine (and if you only have one user then a user install doesn't affect anything).

[MikhailArkhipov]

321e204