The Wayback Machine - http://web.archive.org/web/20230722053534/https://github.com/RupertBenWiser/Web-Environment-Integrity/pull/29
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify language #29

Closed
wants to merge 1 commit into from
Closed

Clarify language #29

wants to merge 1 commit into from
+4 −9

Conversation

ShittyKopper
Copy link

#28

perillamint
perillamint approved these changes Jul 19, 2023
View reviewed changes
Copy link

@perillamint perillamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

kleinesfilmroellchen
kleinesfilmroellchen approved these changes Jul 19, 2023
View reviewed changes
Copy link

@kleinesfilmroellchen kleinesfilmroellchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adryzz
adryzz approved these changes Jul 19, 2023
View reviewed changes
Copy link

@adryzz adryzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diederikdehaas
Copy link

I think the file name extension is rather fitting: docs/spec.bs

2minwia
2minwia approved these changes Jul 19, 2023
View reviewed changes
Copy link

@2minwia 2minwia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks #swag to me

zyzzyxdonta
zyzzyxdonta approved these changes Jul 19, 2023
View reviewed changes
Copy link

@zyzzyxdonta zyzzyxdonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shippit!

@mauke
Copy link

mauke commented Jul 19, 2023

If the user
has squandered the confidence of the website
and could only win it back
by redoubled work, would it not in that case
be simpler for the website
to close the user
and visit another?

tylermurphy534
tylermurphy534 approved these changes Jul 19, 2023
View reviewed changes
Copy link

@tylermurphy534 tylermurphy534 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

wwahammy
wwahammy approved these changes Jul 19, 2023
View reviewed changes
Copy link

@wwahammy wwahammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good correction, I support merging.

@coupcelle
Copy link

coupcelle commented Jul 19, 2023 •
edited

excellent self-documenting code, LGTM
can tell that this was written by a #CertifiedRockstarDeveloper

mpldr
mpldr approved these changes Jul 19, 2023
View reviewed changes
Copy link

@mpldr mpldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this clears it up very well.

dougfinnie
dougfinnie approved these changes Jul 19, 2023
View reviewed changes
Copy link

@dougfinnie dougfinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer on the intent, nice work.

monoxane
monoxane approved these changes Jul 20, 2023
View reviewed changes
Copy link

@monoxane monoxane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, The shareholders will love the additional value provided. LGTM.

Lana-chan
Lana-chan approved these changes Jul 20, 2023
View reviewed changes
Copy link

@Lana-chan Lana-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rbos
rbos approved these changes Jul 20, 2023
View reviewed changes
Copy link

@rbos rbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification; no notes.

chfour
chfour approved these changes Jul 20, 2023
View reviewed changes
Copy link

@chfour chfour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep lgtm

@eudoxos eudoxos mentioned this pull request Jul 20, 2023
Closed
ThatOneCalculator
ThatOneCalculator approved these changes Jul 20, 2023
View reviewed changes
Copy link

@ThatOneCalculator ThatOneCalculator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

rugk
rugk approved these changes Jul 20, 2023
View reviewed changes
Copy link

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

This was referenced Jul 20, 2023
Closed
Closed
kg7y added a commit to j1oi/github-drama that referenced this pull request Jul 21, 2023
@kg7y
WEI drama: archive the issue and PR.
36ca5f2 
WEI drama:
archive the issue and PR.
RupertBenWiser/Web-Environment-Integrity#28
RupertBenWiser/Web-Environment-Integrity#29
github-drama#60
@kg7y kg7y mentioned this pull request Jul 21, 2023
Open
Repository owner locked and limited conversation to collaborators Jul 21, 2023
@yoavweiss yoavweiss closed this Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chfour chfour chfour approved these changes

@JulianHeuser JulianHeuser JulianHeuser approved these changes

@PaulusParssinen PaulusParssinen PaulusParssinen approved these changes

@tylermurphy534 tylermurphy534 tylermurphy534 approved these changes

@kleinesfilmroellchen kleinesfilmroellchen kleinesfilmroellchen approved these changes

@Tau5 Tau5 Tau5 approved these changes

@Jack5079 Jack5079 Jack5079 approved these changes

@uazo uazo uazo approved these changes

@lunaneff lunaneff lunaneff approved these changes

@nononymousse nononymousse nononymousse approved these changes

@mpldr mpldr mpldr approved these changes

@pr0gr8mm3r pr0gr8mm3r pr0gr8mm3r approved these changes

@ChineseMarc ChineseMarc ChineseMarc approved these changes

@owocean owocean owocean approved these changes

@ThatOneCalculator ThatOneCalculator ThatOneCalculator approved these changes

@mc776 mc776 mc776 approved these changes

@adryzz adryzz adryzz approved these changes

@BinBashBanana BinBashBanana BinBashBanana approved these changes

@joebobbio joebobbio joebobbio approved these changes

@Kuuuube Kuuuube Kuuuube approved these changes

@natep-tech natep-tech natep-tech approved these changes

@comradef191 comradef191 comradef191 approved these changes

@brendanno brendanno brendanno approved these changes

@TRezendes TRezendes TRezendes approved these changes

@coricarson coricarson coricarson approved these changes

@ethanalker ethanalker ethanalker approved these changes

@HellyTubbies HellyTubbies HellyTubbies approved these changes

@Written0489 Written0489 Written0489 approved these changes

@stop-treachery stop-treachery stop-treachery approved these changes

@fautz fautz fautz approved these changes

@Maffsie Maffsie Maffsie approved these changes

@wwahammy wwahammy wwahammy approved these changes

@theseer theseer theseer approved these changes

@dougfinnie dougfinnie dougfinnie approved these changes

@derickr derickr derickr approved these changes

@cybik cybik cybik approved these changes

@rbos rbos rbos approved these changes

@JordanMatuschka JordanMatuschka JordanMatuschka approved these changes

@yerdua yerdua yerdua approved these changes

@perillamint perillamint perillamint approved these changes

@h3x4d3c1m4l h3x4d3c1m4l h3x4d3c1m4l approved these changes

@2minwia 2minwia 2minwia approved these changes

@a1batross a1batross a1batross approved these changes

@lewisje lewisje lewisje approved these changes

@ryanw ryanw ryanw approved these changes

@num13ru num13ru num13ru approved these changes

@Zumorica Zumorica Zumorica approved these changes

@Lana-chan Lana-chan Lana-chan approved these changes

@sparked435 sparked435 sparked435 approved these changes

@4ndv 4ndv 4ndv approved these changes

@rugk rugk rugk approved these changes

@Capital-EX Capital-EX Capital-EX approved these changes

@zyzzyxdonta zyzzyxdonta zyzzyxdonta approved these changes

@monoxane monoxane monoxane approved these changes

@FranciscoPombal FranciscoPombal FranciscoPombal approved these changes

@ninelore ninelore ninelore approved these changes

@Arteneko Arteneko Arteneko approved these changes

@shiroeni shiroeni shiroeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet