Fix Job URL format for Github Actions#10514
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063922
Total [baseline] (10.959 s) : 0, 10958967
Agent [candidate] (1.064 s) : 0, 1064169
Total [candidate] (10.876 s) : 0, 10875612
section appsec
Agent [baseline] (1.261 s) : 0, 1260545
Total [baseline] (11.171 s) : 0, 11170573
Agent [candidate] (1.25 s) : 0, 1249899
Total [candidate] (11.207 s) : 0, 11207121
section iast
Agent [baseline] (1.234 s) : 0, 1234311
Total [baseline] (11.112 s) : 0, 11111803
Agent [candidate] (1.241 s) : 0, 1241345
Total [candidate] (11.155 s) : 0, 11155184
section profiling
Agent [baseline] (1.194 s) : 0, 1194399
Total [baseline] (11.021 s) : 0, 11021207
Agent [candidate] (1.193 s) : 0, 1192966
Total [candidate] (11.056 s) : 0, 11056341
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (628.388 ms) : 0, 628388
BytebuddyAgent [candidate] (627.643 ms) : 0, 627643
AgentMeter [baseline] (28.844 ms) : 0, 28844
AgentMeter [candidate] (28.806 ms) : 0, 28806
GlobalTracer [baseline] (257.227 ms) : 0, 257227
GlobalTracer [candidate] (257.794 ms) : 0, 257794
AppSec [baseline] (32.714 ms) : 0, 32714
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (62.513 ms) : 0, 62513
Debugger [candidate] (63.355 ms) : 0, 63355
Remote Config [baseline] (637.989 µs) : 0, 638
Remote Config [candidate] (614.736 µs) : 0, 615
Telemetry [baseline] (11.564 ms) : 0, 11564
Telemetry [candidate] (12.219 ms) : 0, 12219
Flare Poller [baseline] (5.467 ms) : 0, 5467
Flare Poller [candidate] (4.561 ms) : 0, 4561
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (670.015 ms) : 0, 670015
BytebuddyAgent [candidate] (664.239 ms) : 0, 664239
AgentMeter [baseline] (12.211 ms) : 0, 12211
AgentMeter [candidate] (12.04 ms) : 0, 12040
GlobalTracer [baseline] (263.276 ms) : 0, 263276
GlobalTracer [candidate] (260.691 ms) : 0, 260691
AppSec [baseline] (170.205 ms) : 0, 170205
AppSec [candidate] (169.318 ms) : 0, 169318
Debugger [baseline] (68.484 ms) : 0, 68484
Debugger [candidate] (67.772 ms) : 0, 67772
Remote Config [baseline] (685.985 µs) : 0, 686
Remote Config [candidate] (700.123 µs) : 0, 700
Telemetry [baseline] (9.185 ms) : 0, 9185
Telemetry [candidate] (9.25 ms) : 0, 9250
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (3.76 ms) : 0, 3760
IAST [baseline] (25.997 ms) : 0, 25997
IAST [candidate] (25.404 ms) : 0, 25404
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (797.279 ms) : 0, 797279
BytebuddyAgent [candidate] (802.168 ms) : 0, 802168
AgentMeter [baseline] (11.225 ms) : 0, 11225
AgentMeter [candidate] (11.523 ms) : 0, 11523
GlobalTracer [baseline] (248.881 ms) : 0, 248881
GlobalTracer [candidate] (249.82 ms) : 0, 249820
AppSec [baseline] (31.542 ms) : 0, 31542
AppSec [candidate] (32.577 ms) : 0, 32577
Debugger [baseline] (69.228 ms) : 0, 69228
Debugger [candidate] (68.809 ms) : 0, 68809
Remote Config [baseline] (549.99 µs) : 0, 550
Remote Config [candidate] (544.237 µs) : 0, 544
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.705 ms) : 0, 8705
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.512 ms) : 0, 3512
IAST [baseline] (26.895 ms) : 0, 26895
IAST [candidate] (27.099 ms) : 0, 27099
section profiling
ProfilingAgent [baseline] (99.927 ms) : 0, 99927
ProfilingAgent [candidate] (99.093 ms) : 0, 99093
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (684.038 ms) : 0, 684038
BytebuddyAgent [candidate] (683.697 ms) : 0, 683697
AgentMeter [baseline] (8.592 ms) : 0, 8592
AgentMeter [candidate] (8.62 ms) : 0, 8620
GlobalTracer [baseline] (216.586 ms) : 0, 216586
GlobalTracer [candidate] (216.444 ms) : 0, 216444
AppSec [baseline] (32.42 ms) : 0, 32420
AppSec [candidate] (32.642 ms) : 0, 32642
Debugger [baseline] (68.041 ms) : 0, 68041
Debugger [candidate] (67.955 ms) : 0, 67955
Remote Config [baseline] (625.28 µs) : 0, 625
Remote Config [candidate] (601.926 µs) : 0, 602
Telemetry [baseline] (8.979 ms) : 0, 8979
Telemetry [candidate] (8.836 ms) : 0, 8836
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.848 ms) : 0, 3848
Profiling [baseline] (100.5 ms) : 0, 100500
Profiling [candidate] (99.672 ms) : 0, 99672
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070868
Total [baseline] (8.798 s) : 0, 8797904
Agent [candidate] (1.063 s) : 0, 1062648
Total [candidate] (8.769 s) : 0, 8768948
section iast
Agent [baseline] (1.231 s) : 0, 1230511
Total [baseline] (9.441 s) : 0, 9440984
Agent [candidate] (1.239 s) : 0, 1239281
Total [candidate] (9.428 s) : 0, 9427511
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (633.005 ms) : 0, 633005
BytebuddyAgent [candidate] (628.947 ms) : 0, 628947
AgentMeter [baseline] (29.176 ms) : 0, 29176
AgentMeter [candidate] (28.923 ms) : 0, 28923
GlobalTracer [baseline] (258.993 ms) : 0, 258993
GlobalTracer [candidate] (257.965 ms) : 0, 257965
AppSec [baseline] (32.991 ms) : 0, 32991
AppSec [candidate] (32.649 ms) : 0, 32649
Debugger [baseline] (60.778 ms) : 0, 60778
Debugger [candidate] (61.03 ms) : 0, 61030
Remote Config [baseline] (623.617 µs) : 0, 624
Remote Config [candidate] (681.509 µs) : 0, 682
Telemetry [baseline] (12.358 ms) : 0, 12358
Telemetry [candidate] (9.875 ms) : 0, 9875
Flare Poller [baseline] (6.179 ms) : 0, 6179
Flare Poller [candidate] (6.142 ms) : 0, 6142
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (794.264 ms) : 0, 794264
BytebuddyAgent [candidate] (801.124 ms) : 0, 801124
AgentMeter [baseline] (11.24 ms) : 0, 11240
AgentMeter [candidate] (11.49 ms) : 0, 11490
GlobalTracer [baseline] (248.399 ms) : 0, 248399
GlobalTracer [candidate] (249.573 ms) : 0, 249573
AppSec [baseline] (32.404 ms) : 0, 32404
AppSec [candidate] (31.798 ms) : 0, 31798
Debugger [baseline] (68.006 ms) : 0, 68006
Debugger [candidate] (68.716 ms) : 0, 68716
Remote Config [baseline] (552.036 µs) : 0, 552
Remote Config [candidate] (546.624 µs) : 0, 547
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (8.724 ms) : 0, 8724
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.549 ms) : 0, 3549
IAST [baseline] (26.835 ms) : 0, 26835
IAST [candidate] (27.115 ms) : 0, 27115
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (17.862 ms) : 17682, 18042
. : milestone, 17862,
appsec (18.61 ms) : 18420, 18801
. : milestone, 18610,
code_origins (17.607 ms) : 17432, 17783
. : milestone, 17607,
iast (17.787 ms) : 17610, 17963
. : milestone, 17787,
profiling (18.972 ms) : 18784, 19161
. : milestone, 18972,
tracing (17.851 ms) : 17672, 18030
. : milestone, 17851,
section candidate
no_agent (18.312 ms) : 18127, 18496
. : milestone, 18312,
appsec (19.506 ms) : 19308, 19704
. : milestone, 19506,
code_origins (18.785 ms) : 18592, 18979
. : milestone, 18785,
iast (17.742 ms) : 17567, 17917
. : milestone, 17742,
profiling (18.558 ms) : 18374, 18743
. : milestone, 18558,
tracing (17.546 ms) : 17374, 17718
. : milestone, 17546,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.22 ms) : 3172, 3267
. : milestone, 3220,
iast_FULL (5.75 ms) : 5692, 5808
. : milestone, 5750,
iast_GLOBAL (3.689 ms) : 3624, 3754
. : milestone, 3689,
profiling (2.217 ms) : 2195, 2239
. : milestone, 2217,
tracing (1.854 ms) : 1836, 1872
. : milestone, 1854,
section candidate
no_agent (1.171 ms) : 1160, 1183
. : milestone, 1171,
iast (3.302 ms) : 3256, 3348
. : milestone, 3302,
iast_FULL (5.988 ms) : 5927, 6048
. : milestone, 5988,
iast_GLOBAL (3.562 ms) : 3506, 3617
. : milestone, 3562,
profiling (1.985 ms) : 1968, 2002
. : milestone, 1985,
tracing (1.777 ms) : 1763, 1791
. : milestone, 1777,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
appsec (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
iast (17.647 s) : 17647000, 17647000
. : milestone, 17647000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
tracing (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
section candidate
no_agent (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
appsec (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
iast (18.168 s) : 18168000, 18168000
. : milestone, 18168000,
iast_GLOBAL (17.795 s) : 17795000, 17795000
. : milestone, 17795000,
profiling (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
tracing (14.646 s) : 14646000, 14646000
. : milestone, 14646000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~029260695d, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.799 ms) : 3578, 4020
. : milestone, 3799,
iast (2.263 ms) : 2193, 2332
. : milestone, 2263,
iast_GLOBAL (2.3 ms) : 2231, 2370
. : milestone, 2300,
profiling (2.093 ms) : 2038, 2148
. : milestone, 2093,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.806 ms) : 3580, 4032
. : milestone, 3806,
iast (2.272 ms) : 2202, 2342
. : milestone, 2272,
iast_GLOBAL (2.301 ms) : 2231, 2370
. : milestone, 2301,
profiling (2.101 ms) : 2044, 2157
. : milestone, 2101,
tracing (2.075 ms) : 2021, 2128
. : milestone, 2075,
|
|
|
||
| // Sort by filename in descending order to get the most recent file first | ||
| workerFiles.sort( | ||
| Comparator.comparing(p -> p.getFileName().toString(), Comparator.reverseOrder())); |
There was a problem hiding this comment.
Nitpitck: we don't need to sort the entire list to find the most recent log, a single O(N) pass is enough:
Path mostRecentLog = null;
for (Path workerLog : stream) {
if (mostRecentLog == null ||
workerLog.getFileName().toString().compareTo(mostRecentLog.getFileName().toString()) > 0) {
mostRecentLog = workerLog;
}
}
if (workerLog == null) { return null; }
| if (value.contains(".")) { | ||
| try { | ||
| long longValue = (long) Double.parseDouble(value); | ||
| lastMatch = String.valueOf(longValue); |
There was a problem hiding this comment.
Since you're converting it back to String, could we just do:
int pointIdx = value.indexOf(".");
if (pointIdx != -1) {
lastMatch = value.substring(0, pointIdx);
}
I might be missing things, but looking at the regex it seems like a NumberFormatException is not possible here given how you match the group
There was a problem hiding this comment.
Indeed, good catch. The regex should already be taking care of the validation, addressed in 92af59d
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
@ci.job.urltag for Github Actions with the appropriate@ci.job.idvalue. The new format ishttps://github.com/REPO_NAME/actions/runs/RUN_ID/job/JOB_IDwhile we previously were limited tohttps://github.com/REPO_NAME/commit/COMMIT_SHA/checks:JOB_CHECK_RUN_IDis present, we use it as job id.Motivation
These changes allow users to directly access CI logs with the URL provided, as well as improving the correlation between Test Optimization and CI Visibility.
Additional Notes
Validation in example project: https://github.com/DataDog/danm-testing-repo/pull/8
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-2999