Introduce pagination support for known tests API#10536
Introduce pagination support for known tests API#10536gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066627
Total [baseline] (10.771 s) : 0, 10771469
Agent [candidate] (1.065 s) : 0, 1064590
Total [candidate] (10.925 s) : 0, 10925178
section appsec
Agent [baseline] (1.24 s) : 0, 1240117
Total [baseline] (11.091 s) : 0, 11091075
Agent [candidate] (1.248 s) : 0, 1247895
Total [candidate] (11.041 s) : 0, 11040536
section iast
Agent [baseline] (1.233 s) : 0, 1232525
Total [baseline] (11.218 s) : 0, 11218368
Agent [candidate] (1.235 s) : 0, 1235331
Total [candidate] (11.152 s) : 0, 11152481
section profiling
Agent [baseline] (1.191 s) : 0, 1191043
Total [baseline] (11.05 s) : 0, 11049743
Agent [candidate] (1.194 s) : 0, 1193805
Total [candidate] (11.043 s) : 0, 11042530
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (630.216 ms) : 0, 630216
BytebuddyAgent [candidate] (627.723 ms) : 0, 627723
AgentMeter [baseline] (28.983 ms) : 0, 28983
AgentMeter [candidate] (28.84 ms) : 0, 28840
GlobalTracer [baseline] (258.057 ms) : 0, 258057
GlobalTracer [candidate] (257.644 ms) : 0, 257644
AppSec [baseline] (32.955 ms) : 0, 32955
AppSec [candidate] (32.735 ms) : 0, 32735
Debugger [baseline] (61.572 ms) : 0, 61572
Debugger [candidate] (61.178 ms) : 0, 61178
Remote Config [baseline] (651.217 µs) : 0, 651
Remote Config [candidate] (629.074 µs) : 0, 629
Telemetry [baseline] (13.036 ms) : 0, 13036
Telemetry [candidate] (12.956 ms) : 0, 12956
Flare Poller [baseline] (4.551 ms) : 0, 4551
Flare Poller [candidate] (6.35 ms) : 0, 6350
section appsec
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (658.385 ms) : 0, 658385
BytebuddyAgent [candidate] (663.157 ms) : 0, 663157
AgentMeter [baseline] (11.918 ms) : 0, 11918
AgentMeter [candidate] (12.051 ms) : 0, 12051
GlobalTracer [baseline] (258.261 ms) : 0, 258261
GlobalTracer [candidate] (260.222 ms) : 0, 260222
AppSec [baseline] (168.509 ms) : 0, 168509
AppSec [candidate] (168.713 ms) : 0, 168713
Debugger [baseline] (67.864 ms) : 0, 67864
Debugger [candidate] (67.922 ms) : 0, 67922
Remote Config [baseline] (661.982 µs) : 0, 662
Remote Config [candidate] (654.807 µs) : 0, 655
Telemetry [baseline] (9.071 ms) : 0, 9071
Telemetry [candidate] (9.133 ms) : 0, 9133
Flare Poller [baseline] (3.678 ms) : 0, 3678
Flare Poller [candidate] (3.739 ms) : 0, 3739
IAST [baseline] (25.305 ms) : 0, 25305
IAST [candidate] (25.596 ms) : 0, 25596
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (796.309 ms) : 0, 796309
BytebuddyAgent [candidate] (797.321 ms) : 0, 797321
AgentMeter [baseline] (11.223 ms) : 0, 11223
AgentMeter [candidate] (11.277 ms) : 0, 11277
GlobalTracer [baseline] (248.578 ms) : 0, 248578
GlobalTracer [candidate] (249.253 ms) : 0, 249253
AppSec [baseline] (34.043 ms) : 0, 34043
AppSec [candidate] (32.526 ms) : 0, 32526
Debugger [baseline] (66.427 ms) : 0, 66427
Debugger [candidate] (68.588 ms) : 0, 68588
Remote Config [baseline] (539.682 µs) : 0, 540
Remote Config [candidate] (545.904 µs) : 0, 546
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.807 ms) : 0, 8807
Flare Poller [baseline] (3.486 ms) : 0, 3486
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (26.847 ms) : 0, 26847
IAST [candidate] (26.885 ms) : 0, 26885
section profiling
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (682.622 ms) : 0, 682622
BytebuddyAgent [candidate] (683.675 ms) : 0, 683675
AgentMeter [baseline] (8.531 ms) : 0, 8531
AgentMeter [candidate] (8.632 ms) : 0, 8632
GlobalTracer [baseline] (215.722 ms) : 0, 215722
GlobalTracer [candidate] (216.522 ms) : 0, 216522
AppSec [baseline] (32.301 ms) : 0, 32301
AppSec [candidate] (32.647 ms) : 0, 32647
Debugger [baseline] (67.765 ms) : 0, 67765
Debugger [candidate] (67.895 ms) : 0, 67895
Remote Config [baseline] (601.737 µs) : 0, 602
Remote Config [candidate] (600.197 µs) : 0, 600
Telemetry [baseline] (8.886 ms) : 0, 8886
Telemetry [candidate] (8.935 ms) : 0, 8935
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.785 ms) : 0, 3785
ProfilingAgent [baseline] (99.6 ms) : 0, 99600
ProfilingAgent [candidate] (99.89 ms) : 0, 99890
Profiling [baseline] (100.163 ms) : 0, 100163
Profiling [candidate] (100.455 ms) : 0, 100455
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067668
Total [baseline] (8.732 s) : 0, 8732036
Agent [candidate] (1.068 s) : 0, 1068437
Total [candidate] (8.751 s) : 0, 8750916
section iast
Agent [baseline] (1.235 s) : 0, 1234957
Total [baseline] (9.424 s) : 0, 9423797
Agent [candidate] (1.232 s) : 0, 1232360
Total [candidate] (9.393 s) : 0, 9392633
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (630.874 ms) : 0, 630874
BytebuddyAgent [candidate] (630.181 ms) : 0, 630181
AgentMeter [baseline] (29.011 ms) : 0, 29011
AgentMeter [candidate] (29.059 ms) : 0, 29059
GlobalTracer [baseline] (257.951 ms) : 0, 257951
GlobalTracer [candidate] (258.574 ms) : 0, 258574
AppSec [baseline] (32.759 ms) : 0, 32759
AppSec [candidate] (32.801 ms) : 0, 32801
Debugger [baseline] (60.547 ms) : 0, 60547
Debugger [candidate] (60.426 ms) : 0, 60426
Remote Config [baseline] (632.473 µs) : 0, 632
Remote Config [candidate] (639.129 µs) : 0, 639
Telemetry [baseline] (13.12 ms) : 0, 13120
Telemetry [candidate] (12.337 ms) : 0, 12337
Flare Poller [baseline] (6.09 ms) : 0, 6090
Flare Poller [candidate] (7.764 ms) : 0, 7764
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (798.967 ms) : 0, 798967
BytebuddyAgent [candidate] (796.636 ms) : 0, 796636
AgentMeter [baseline] (11.433 ms) : 0, 11433
AgentMeter [candidate] (11.267 ms) : 0, 11267
GlobalTracer [baseline] (248.569 ms) : 0, 248569
GlobalTracer [candidate] (248.709 ms) : 0, 248709
AppSec [baseline] (33.996 ms) : 0, 33996
AppSec [candidate] (33.099 ms) : 0, 33099
Debugger [baseline] (65.557 ms) : 0, 65557
Debugger [candidate] (66.572 ms) : 0, 66572
Remote Config [baseline] (537.044 µs) : 0, 537
Remote Config [candidate] (546.57 µs) : 0, 547
Telemetry [baseline] (8.623 ms) : 0, 8623
Telemetry [candidate] (8.724 ms) : 0, 8724
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (27.07 ms) : 0, 27070
IAST [candidate] (26.762 ms) : 0, 26762
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1175, 1198
. : milestone, 1187,
iast (3.125 ms) : 3091, 3159
. : milestone, 3125,
iast_FULL (5.876 ms) : 5816, 5936
. : milestone, 5876,
iast_GLOBAL (3.529 ms) : 3469, 3589
. : milestone, 3529,
profiling (1.931 ms) : 1914, 1947
. : milestone, 1931,
tracing (1.81 ms) : 1795, 1825
. : milestone, 1810,
section candidate
no_agent (1.218 ms) : 1206, 1230
. : milestone, 1218,
iast (3.206 ms) : 3163, 3248
. : milestone, 3206,
iast_FULL (5.92 ms) : 5859, 5980
. : milestone, 5920,
iast_GLOBAL (3.519 ms) : 3470, 3568
. : milestone, 3519,
profiling (2.124 ms) : 2104, 2145
. : milestone, 2124,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (18.068 ms) : 17881, 18256
. : milestone, 18068,
appsec (18.784 ms) : 18595, 18973
. : milestone, 18784,
code_origins (17.626 ms) : 17451, 17801
. : milestone, 17626,
iast (17.624 ms) : 17452, 17796
. : milestone, 17624,
profiling (18.656 ms) : 18474, 18839
. : milestone, 18656,
tracing (17.515 ms) : 17342, 17689
. : milestone, 17515,
section candidate
no_agent (18.438 ms) : 18245, 18630
. : milestone, 18438,
appsec (18.405 ms) : 18216, 18594
. : milestone, 18405,
code_origins (17.79 ms) : 17612, 17967
. : milestone, 17790,
iast (17.61 ms) : 17434, 17785
. : milestone, 17610,
profiling (18.898 ms) : 18712, 19085
. : milestone, 18898,
tracing (17.713 ms) : 17538, 17889
. : milestone, 17713,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
iast_GLOBAL (17.824 s) : 17824000, 17824000
. : milestone, 17824000,
profiling (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
tracing (14.608 s) : 14608000, 14608000
. : milestone, 14608000,
section candidate
no_agent (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
appsec (14.644 s) : 14644000, 14644000
. : milestone, 14644000,
iast (18.747 s) : 18747000, 18747000
. : milestone, 18747000,
iast_GLOBAL (17.729 s) : 17729000, 17729000
. : milestone, 17729000,
profiling (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
tracing (14.619 s) : 14619000, 14619000
. : milestone, 14619000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~650d7888b9, baseline=1.60.0-SNAPSHOT~d10055d2a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.77 ms) : 3549, 3991
. : milestone, 3770,
iast (2.251 ms) : 2183, 2320
. : milestone, 2251,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.074 ms) : 2020, 2129
. : milestone, 2074,
tracing (2.07 ms) : 2017, 2124
. : milestone, 2070,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.783 ms) : 3558, 4009
. : milestone, 3783,
iast (2.253 ms) : 2184, 2322
. : milestone, 2253,
iast_GLOBAL (2.289 ms) : 2220, 2358
. : milestone, 2289,
profiling (2.071 ms) : 2016, 2125
. : milestone, 2071,
tracing (2.06 ms) : 2007, 2114
. : milestone, 2060,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
|
||
| @Json(name = "page_info") | ||
| @Nullable | ||
| private final PageInfoRequest pageInfo; |
There was a problem hiding this comment.
I think we're now officially past the point where we've started abusing the tracer environment DTO :)
Page info is not part of the environment where the tracer runs.
Besides, this DTO is used in several places, and not in all of them page info is useful.
From the code point of view it'd be best to create a dedicated request DTO class takes in the environment and the page
There was a problem hiding this comment.
Agreed, included the dedicated DTO in 263210c 👍
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
daniel.mohedano@datadoghq.com cancelled this merge request build |
|
/merge --cancel |
|
View all feedbacks in Devflow UI.
|
|
/merge -m squash |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
282cf78
into
master
What Does This Do
Motivation
To reduce load and avoid timeouts and issues on the backend, the endpoint as been updated to make use of pagination.
Additional Information
Validation in example project: https://github.com/DataDog/danm-testing-repo/pull/9
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-2991