Reduce verbosity of StatsD connection errors#10618
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom Mar 11, 2026
Merged
Reduce verbosity of StatsD connection errors#10618gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062146
Total [baseline] (8.719 s) : 0, 8718724
Agent [candidate] (1.067 s) : 0, 1066505
Total [candidate] (8.757 s) : 0, 8757040
section iast
Agent [baseline] (1.23 s) : 0, 1229710
Total [baseline] (9.329 s) : 0, 9328710
Agent [candidate] (1.238 s) : 0, 1238015
Total [candidate] (9.436 s) : 0, 9435609
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (626.45 ms) : 0, 626450
BytebuddyAgent [candidate] (628.233 ms) : 0, 628233
AgentMeter [baseline] (28.943 ms) : 0, 28943
AgentMeter [candidate] (29.323 ms) : 0, 29323
GlobalTracer [baseline] (256.794 ms) : 0, 256794
GlobalTracer [candidate] (259.393 ms) : 0, 259393
AppSec [baseline] (32.901 ms) : 0, 32901
AppSec [candidate] (33.224 ms) : 0, 33224
Debugger [baseline] (64.0 ms) : 0, 64000
Debugger [candidate] (62.193 ms) : 0, 62193
Remote Config [baseline] (598.398 µs) : 0, 598
Remote Config [candidate] (623.749 µs) : 0, 624
Telemetry [baseline] (9.769 ms) : 0, 9769
Telemetry [candidate] (12.321 ms) : 0, 12321
Flare Poller [baseline] (5.415 ms) : 0, 5415
Flare Poller [candidate] (3.837 ms) : 0, 3837
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (795.125 ms) : 0, 795125
BytebuddyAgent [candidate] (800.971 ms) : 0, 800971
AgentMeter [baseline] (11.304 ms) : 0, 11304
AgentMeter [candidate] (11.558 ms) : 0, 11558
GlobalTracer [baseline] (247.098 ms) : 0, 247098
GlobalTracer [candidate] (248.568 ms) : 0, 248568
AppSec [baseline] (31.387 ms) : 0, 31387
AppSec [candidate] (32.286 ms) : 0, 32286
Debugger [baseline] (68.063 ms) : 0, 68063
Debugger [candidate] (67.241 ms) : 0, 67241
Remote Config [baseline] (539.438 µs) : 0, 539
Remote Config [candidate] (564.562 µs) : 0, 565
Telemetry [baseline] (8.581 ms) : 0, 8581
Telemetry [candidate] (8.752 ms) : 0, 8752
Flare Poller [baseline] (3.433 ms) : 0, 3433
Flare Poller [candidate] (3.54 ms) : 0, 3540
IAST [baseline] (27.047 ms) : 0, 27047
IAST [candidate] (27.203 ms) : 0, 27203
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079879
Total [baseline] (10.924 s) : 0, 10924194
Agent [candidate] (1.066 s) : 0, 1066204
Total [candidate] (10.895 s) : 0, 10894968
section appsec
Agent [baseline] (1.236 s) : 0, 1235579
Total [baseline] (11.034 s) : 0, 11034406
Agent [candidate] (1.247 s) : 0, 1246727
Total [candidate] (11.197 s) : 0, 11197102
section iast
Agent [baseline] (1.25 s) : 0, 1250212
Total [baseline] (11.26 s) : 0, 11260145
Agent [candidate] (1.233 s) : 0, 1232897
Total [candidate] (11.25 s) : 0, 11249851
section profiling
Agent [baseline] (1.192 s) : 0, 1191984
Total [baseline] (10.917 s) : 0, 10916970
Agent [candidate] (1.192 s) : 0, 1191883
Total [candidate] (10.938 s) : 0, 10938341
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (636.7 ms) : 0, 636700
BytebuddyAgent [candidate] (628.491 ms) : 0, 628491
AgentMeter [baseline] (29.587 ms) : 0, 29587
AgentMeter [candidate] (29.1 ms) : 0, 29100
GlobalTracer [baseline] (260.689 ms) : 0, 260689
GlobalTracer [candidate] (257.477 ms) : 0, 257477
AppSec [baseline] (33.653 ms) : 0, 33653
AppSec [candidate] (32.836 ms) : 0, 32836
Debugger [baseline] (63.124 ms) : 0, 63124
Debugger [candidate] (63.573 ms) : 0, 63573
Remote Config [baseline] (630.315 µs) : 0, 630
Remote Config [candidate] (616.56 µs) : 0, 617
Telemetry [baseline] (12.548 ms) : 0, 12548
Telemetry [candidate] (10.679 ms) : 0, 10679
Flare Poller [baseline] (5.53 ms) : 0, 5530
Flare Poller [candidate] (6.116 ms) : 0, 6116
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (655.499 ms) : 0, 655499
BytebuddyAgent [candidate] (662.82 ms) : 0, 662820
AgentMeter [baseline] (11.99 ms) : 0, 11990
AgentMeter [candidate] (12.108 ms) : 0, 12108
GlobalTracer [baseline] (258.008 ms) : 0, 258008
GlobalTracer [candidate] (259.644 ms) : 0, 259644
AppSec [baseline] (167.516 ms) : 0, 167516
AppSec [candidate] (168.184 ms) : 0, 168184
Debugger [baseline] (66.402 ms) : 0, 66402
Debugger [candidate] (67.067 ms) : 0, 67067
Remote Config [baseline] (685.932 µs) : 0, 686
Remote Config [candidate] (682.797 µs) : 0, 683
Telemetry [baseline] (9.353 ms) : 0, 9353
Telemetry [candidate] (9.536 ms) : 0, 9536
Flare Poller [baseline] (3.662 ms) : 0, 3662
Flare Poller [candidate] (3.668 ms) : 0, 3668
IAST [baseline] (25.276 ms) : 0, 25276
IAST [candidate] (25.539 ms) : 0, 25539
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (808.396 ms) : 0, 808396
BytebuddyAgent [candidate] (795.939 ms) : 0, 795939
AgentMeter [baseline] (11.831 ms) : 0, 11831
AgentMeter [candidate] (11.315 ms) : 0, 11315
GlobalTracer [baseline] (250.253 ms) : 0, 250253
GlobalTracer [candidate] (247.579 ms) : 0, 247579
AppSec [baseline] (32.934 ms) : 0, 32934
AppSec [candidate] (33.489 ms) : 0, 33489
Debugger [baseline] (68.95 ms) : 0, 68950
Debugger [candidate] (67.528 ms) : 0, 67528
Remote Config [baseline] (545.476 µs) : 0, 545
Remote Config [candidate] (544.113 µs) : 0, 544
Telemetry [baseline] (8.701 ms) : 0, 8701
Telemetry [candidate] (8.769 ms) : 0, 8769
Flare Poller [baseline] (3.51 ms) : 0, 3510
Flare Poller [candidate] (3.538 ms) : 0, 3538
IAST [baseline] (27.651 ms) : 0, 27651
IAST [candidate] (27.078 ms) : 0, 27078
section profiling
crashtracking [baseline] (1.169 ms) : 0, 1169
crashtracking [candidate] (1.166 ms) : 0, 1166
BytebuddyAgent [baseline] (682.81 ms) : 0, 682810
BytebuddyAgent [candidate] (682.775 ms) : 0, 682775
AgentMeter [baseline] (8.561 ms) : 0, 8561
AgentMeter [candidate] (8.551 ms) : 0, 8551
GlobalTracer [baseline] (216.128 ms) : 0, 216128
GlobalTracer [candidate] (215.965 ms) : 0, 215965
AppSec [baseline] (32.794 ms) : 0, 32794
AppSec [candidate] (32.61 ms) : 0, 32610
Debugger [baseline] (67.128 ms) : 0, 67128
Debugger [candidate] (67.536 ms) : 0, 67536
Remote Config [baseline] (634.476 µs) : 0, 634
Remote Config [candidate] (622.598 µs) : 0, 623
Telemetry [baseline] (8.917 ms) : 0, 8917
Telemetry [candidate] (8.979 ms) : 0, 8979
Flare Poller [baseline] (3.729 ms) : 0, 3729
Flare Poller [candidate] (3.802 ms) : 0, 3802
ProfilingAgent [baseline] (99.377 ms) : 0, 99377
ProfilingAgent [candidate] (98.991 ms) : 0, 98991
Profiling [baseline] (99.953 ms) : 0, 99953
Profiling [candidate] (99.568 ms) : 0, 99568
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section baseline
no_agent (19.146 ms) : 18946, 19346
. : milestone, 19146,
appsec (18.833 ms) : 18643, 19023
. : milestone, 18833,
code_origins (17.815 ms) : 17637, 17994
. : milestone, 17815,
iast (17.696 ms) : 17521, 17872
. : milestone, 17696,
profiling (19.493 ms) : 19294, 19692
. : milestone, 19493,
tracing (18.319 ms) : 18135, 18504
. : milestone, 18319,
section candidate
no_agent (17.818 ms) : 17637, 17999
. : milestone, 17818,
appsec (18.634 ms) : 18444, 18825
. : milestone, 18634,
code_origins (17.412 ms) : 17239, 17585
. : milestone, 17412,
iast (17.576 ms) : 17402, 17750
. : milestone, 17576,
profiling (19.563 ms) : 19365, 19762
. : milestone, 19563,
tracing (17.65 ms) : 17472, 17827
. : milestone, 17650,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1200
. : milestone, 1188,
iast (3.156 ms) : 3114, 3198
. : milestone, 3156,
iast_FULL (5.852 ms) : 5795, 5910
. : milestone, 5852,
iast_GLOBAL (3.539 ms) : 3479, 3599
. : milestone, 3539,
profiling (2.05 ms) : 2032, 2069
. : milestone, 2050,
tracing (1.758 ms) : 1744, 1772
. : milestone, 1758,
section candidate
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.156 ms) : 3115, 3197
. : milestone, 3156,
iast_FULL (5.551 ms) : 5496, 5606
. : milestone, 5551,
iast_GLOBAL (3.607 ms) : 3545, 3668
. : milestone, 3607,
profiling (2.114 ms) : 2095, 2133
. : milestone, 2114,
tracing (1.823 ms) : 1807, 1838
. : milestone, 1823,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.506 ms) : 2451, 2560
. : milestone, 2506,
iast (2.237 ms) : 2168, 2305
. : milestone, 2237,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.111 ms) : 2055, 2168
. : milestone, 2111,
tracing (2.072 ms) : 2019, 2125
. : milestone, 2072,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.725 ms) : 3510, 3941
. : milestone, 3725,
iast (2.242 ms) : 2174, 2311
. : milestone, 2242,
iast_GLOBAL (2.293 ms) : 2224, 2363
. : milestone, 2293,
profiling (2.088 ms) : 2032, 2144
. : milestone, 2088,
tracing (2.046 ms) : 1993, 2099
. : milestone, 2046,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~3c80943f55, baseline=1.60.0-SNAPSHOT~68b7b69797
dateFormat X
axisFormat %s
section baseline
no_agent (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
iast_GLOBAL (17.739 s) : 17739000, 17739000
. : milestone, 17739000,
profiling (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
iast (18.115 s) : 18115000, 18115000
. : milestone, 18115000,
iast_GLOBAL (17.807 s) : 17807000, 17807000
. : milestone, 17807000,
profiling (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
tracing (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
|
mcculls
reviewed
Feb 25, 2026
| } else { | ||
| // Only report the top and root cause message | ||
| Throwable rootCause = t; | ||
| while (rootCause.getCause() != null) { |
Contributor
There was a problem hiding this comment.
It's rare, but potentially .getCause() can lead to a cycle - so consider adding a numerical limit to this iteration, like in https://github.com/DataDog/dd-trace-java/blob/master/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/util/ExceptionHelper.java#L71
Contributor
Author
There was a problem hiding this comment.
Good call, thanks! 🙏
Just pushed a fix
…in StatsD connection error logging
PerfectSlayer
force-pushed
the
bbujon/jffi-log-level
branch
from
1478d04 to
3c80943
Compare
mcculls
approved these changes
Mar 5, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 3c63c4f: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
bric3
approved these changes
Mar 5, 2026
Comment on lines
+177
to
+192
| if (log.isDebugEnabled()) { | ||
| // Display full stack traces on debug logs | ||
| log.warn("Unable to create StatsD client - {} - Will not retry", statsDAddress(), t); | ||
| } else { | ||
| Throwable rootCause = t; | ||
| int i = 100; // arbitrary limit to avoid infinite loops with cycling causes | ||
| do { | ||
| rootCause = rootCause.getCause(); | ||
| i--; | ||
| } while (rootCause.getCause() != null && i > 0); | ||
| log.warn( | ||
| "Unable to create StatsD client - {} - Will not retry: {}, {}", | ||
| statsDAddress(), | ||
| t.getMessage(), | ||
| rootCause.getMessage()); | ||
| } |
Contributor
There was a problem hiding this comment.
thought: I believe this could be a useful logging feature.
Contributor
Author
There was a problem hiding this comment.
Agreed, I will capture it in the doc
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR reduces verbosity of StatsD connection error.
It keeps full details / stack trace in debug logs.
Motivation
Using read-only file system, users get the following log message which is quite verbose and scary:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.