Skip to content

Refine service name sources for configuration options#10658

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
andrea.marziali/refine-svc-src
Feb 23, 2026
Merged

Refine service name sources for configuration options#10658
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
andrea.marziali/refine-svc-src

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

What Does This Do

This PR refines the service name source introduced with #10607 and refines even more the source when it comes from a configuration option.

In order to keep it as x-tracer as possible, the name of the source is opt.<value> where <value> is the snake case version of the configuration option, stripping dd, dd.trace, etc.

For this, we introduce a ServiceNameSources const holder class containing main sources as UTF8BytesString.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali amarziali added type: enhancement Enhancements and improvements comp: core Tracer core labels Feb 23, 2026
@amarziali amarziali requested review from a team as code owners February 23, 2026 08:04
@amarziali amarziali requested review from mcculls and raphaelgavache and removed request for a team February 23, 2026 08:04
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 23, 2026

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/refine-svc-src
git_commit_date 1771808874 1771846029
git_commit_sha d7515c8 1962e89
See matching parameters
Baseline Candidate
ci_job_date 1771847145 1771847145
ci_job_id 1447057573 1447057573
ci_pipeline_id 98194422 98194422
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce unsure
[-4270.979op/s; -160.194op/s] or [-2.411%; -0.090%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 23, 2026

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/refine-svc-src
git_commit_date 1771808874 1771833352
git_commit_sha d7515c8 d2c630b
See matching parameters
Baseline Candidate
ci_job_date 1771834821 1771834821
ci_job_id 1446471174 1446471174
ci_pipeline_id 98160238 98160238
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario Δ mean throughput
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume better
[+9678.092op/s; +19669.361op/s] or [+3.245%; +6.595%]
See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 23, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/refine-svc-src
git_commit_date 1771808874 1771846029
git_commit_sha d7515c8 1962e89
release_version 1.60.0-SNAPSHOT~d7515c8b3c 1.60.0-SNAPSHOT~1962e89aec
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1771847798 1771847798
ci_job_id 1447057568 1447057568
ci_pipeline_id 98194422 98194422
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-yq7dkapt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-yq7dkapt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081372
Total [baseline] (11.03 s) : 0, 11029715
Agent [candidate] (1.064 s) : 0, 1063681
Total [candidate] (10.769 s) : 0, 10768930
section appsec
Agent [baseline] (1.236 s) : 0, 1236026
Total [baseline] (10.955 s) : 0, 10955447
Agent [candidate] (1.24 s) : 0, 1239603
Total [candidate] (11.053 s) : 0, 11052821
section iast
Agent [baseline] (1.247 s) : 0, 1247090
Total [baseline] (11.333 s) : 0, 11333198
Agent [candidate] (1.232 s) : 0, 1231516
Total [candidate] (11.17 s) : 0, 11169879
section profiling
Agent [baseline] (1.188 s) : 0, 1188073
Total [baseline] (10.91 s) : 0, 10909917
Agent [candidate] (1.19 s) : 0, 1190219
Total [candidate] (10.887 s) : 0, 10886849
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.236 s 154.654 ms (14.3%)
Agent iast 1.247 s 165.718 ms (15.3%)
Agent profiling 1.188 s 106.701 ms (9.9%)
Total tracing 11.03 s -
Total appsec 10.955 s -74.268 ms (-0.7%)
Total iast 11.333 s 303.482 ms (2.8%)
Total profiling 10.91 s -119.798 ms (-1.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.24 s 175.922 ms (16.5%)
Agent iast 1.232 s 167.835 ms (15.8%)
Agent profiling 1.19 s 126.538 ms (11.9%)
Total tracing 10.769 s -
Total appsec 11.053 s 283.891 ms (2.6%)
Total iast 11.17 s 400.949 ms (3.7%)
Total profiling 10.887 s 117.92 ms (1.1%)
gantt
    title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (637.796 ms) : 0, 637796
BytebuddyAgent [candidate] (626.499 ms) : 0, 626499
AgentMeter [baseline] (29.575 ms) : 0, 29575
AgentMeter [candidate] (29.017 ms) : 0, 29017
GlobalTracer [baseline] (260.846 ms) : 0, 260846
GlobalTracer [candidate] (257.171 ms) : 0, 257171
AppSec [baseline] (33.435 ms) : 0, 33435
AppSec [candidate] (32.811 ms) : 0, 32811
Debugger [baseline] (64.637 ms) : 0, 64637
Debugger [candidate] (63.644 ms) : 0, 63644
Remote Config [baseline] (623.135 µs) : 0, 623
Remote Config [candidate] (621.982 µs) : 0, 622
Telemetry [baseline] (10.002 ms) : 0, 10002
Telemetry [candidate] (11.418 ms) : 0, 11418
Flare Poller [baseline] (6.736 ms) : 0, 6736
Flare Poller [candidate] (5.274 ms) : 0, 5274
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (656.707 ms) : 0, 656707
BytebuddyAgent [candidate] (658.664 ms) : 0, 658664
AgentMeter [baseline] (11.886 ms) : 0, 11886
AgentMeter [candidate] (12.008 ms) : 0, 12008
GlobalTracer [baseline] (257.243 ms) : 0, 257243
GlobalTracer [candidate] (258.614 ms) : 0, 258614
IAST [baseline] (25.288 ms) : 0, 25288
IAST [candidate] (25.384 ms) : 0, 25384
AppSec [baseline] (167.583 ms) : 0, 167583
AppSec [candidate] (168.55 ms) : 0, 168550
Debugger [baseline] (66.368 ms) : 0, 66368
Debugger [candidate] (65.578 ms) : 0, 65578
Remote Config [baseline] (649.616 µs) : 0, 650
Remote Config [candidate] (637.016 µs) : 0, 637
Telemetry [baseline] (9.454 ms) : 0, 9454
Telemetry [candidate] (9.412 ms) : 0, 9412
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.643 ms) : 0, 3643
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (806.945 ms) : 0, 806945
BytebuddyAgent [candidate] (795.834 ms) : 0, 795834
AgentMeter [baseline] (11.776 ms) : 0, 11776
AgentMeter [candidate] (11.321 ms) : 0, 11321
GlobalTracer [baseline] (249.849 ms) : 0, 249849
GlobalTracer [candidate] (247.693 ms) : 0, 247693
IAST [baseline] (27.377 ms) : 0, 27377
IAST [candidate] (26.97 ms) : 0, 26970
AppSec [baseline] (33.988 ms) : 0, 33988
AppSec [candidate] (35.518 ms) : 0, 35518
Debugger [baseline] (67.141 ms) : 0, 67141
Debugger [candidate] (64.438 ms) : 0, 64438
Remote Config [baseline] (540.284 µs) : 0, 540
Remote Config [candidate] (535.398 µs) : 0, 535
Telemetry [baseline] (8.634 ms) : 0, 8634
Telemetry [candidate] (8.632 ms) : 0, 8632
Flare Poller [baseline] (3.425 ms) : 0, 3425
Flare Poller [candidate] (3.468 ms) : 0, 3468
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (680.601 ms) : 0, 680601
BytebuddyAgent [candidate] (681.379 ms) : 0, 681379
AgentMeter [baseline] (8.502 ms) : 0, 8502
AgentMeter [candidate] (8.523 ms) : 0, 8523
GlobalTracer [baseline] (215.756 ms) : 0, 215756
GlobalTracer [candidate] (215.844 ms) : 0, 215844
AppSec [baseline] (32.515 ms) : 0, 32515
AppSec [candidate] (32.472 ms) : 0, 32472
Debugger [baseline] (66.765 ms) : 0, 66765
Debugger [candidate] (67.027 ms) : 0, 67027
Remote Config [baseline] (628.879 µs) : 0, 629
Remote Config [candidate] (639.568 µs) : 0, 640
Telemetry [baseline] (8.934 ms) : 0, 8934
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.779 ms) : 0, 3779
Flare Poller [candidate] (3.778 ms) : 0, 3778
ProfilingAgent [baseline] (98.946 ms) : 0, 98946
ProfilingAgent [candidate] (99.781 ms) : 0, 99781
Profiling [baseline] (99.512 ms) : 0, 99512
Profiling [candidate] (100.366 ms) : 0, 100366
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060900
Total [baseline] (8.697 s) : 0, 8696684
Agent [candidate] (1.064 s) : 0, 1064434
Total [candidate] (8.762 s) : 0, 8762406
section iast
Agent [baseline] (1.238 s) : 0, 1237811
Total [baseline] (9.398 s) : 0, 9397960
Agent [candidate] (1.235 s) : 0, 1235237
Total [candidate] (9.346 s) : 0, 9346251
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.238 s 176.911 ms (16.7%)
Total tracing 8.697 s -
Total iast 9.398 s 701.276 ms (8.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.235 s 170.803 ms (16.0%)
Total tracing 8.762 s -
Total iast 9.346 s 583.845 ms (6.7%)
gantt
    title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (625.166 ms) : 0, 625166
BytebuddyAgent [candidate] (627.156 ms) : 0, 627156
AgentMeter [baseline] (28.949 ms) : 0, 28949
AgentMeter [candidate] (29.036 ms) : 0, 29036
GlobalTracer [baseline] (256.401 ms) : 0, 256401
GlobalTracer [candidate] (257.405 ms) : 0, 257405
AppSec [baseline] (32.974 ms) : 0, 32974
AppSec [candidate] (32.902 ms) : 0, 32902
Debugger [baseline] (63.72 ms) : 0, 63720
Debugger [candidate] (63.665 ms) : 0, 63665
Remote Config [baseline] (618.12 µs) : 0, 618
Remote Config [candidate] (634.093 µs) : 0, 634
Telemetry [baseline] (10.683 ms) : 0, 10683
Telemetry [candidate] (11.509 ms) : 0, 11509
Flare Poller [baseline] (5.261 ms) : 0, 5261
Flare Poller [candidate] (4.586 ms) : 0, 4586
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (800.328 ms) : 0, 800328
BytebuddyAgent [candidate] (801.041 ms) : 0, 801041
AgentMeter [baseline] (11.539 ms) : 0, 11539
AgentMeter [candidate] (11.555 ms) : 0, 11555
GlobalTracer [baseline] (248.481 ms) : 0, 248481
GlobalTracer [candidate] (247.188 ms) : 0, 247188
IAST [baseline] (27.19 ms) : 0, 27190
IAST [candidate] (26.915 ms) : 0, 26915
AppSec [baseline] (34.211 ms) : 0, 34211
AppSec [candidate] (33.867 ms) : 0, 33867
Debugger [baseline] (66.006 ms) : 0, 66006
Debugger [candidate] (64.881 ms) : 0, 64881
Remote Config [baseline] (540.962 µs) : 0, 541
Remote Config [candidate] (527.892 µs) : 0, 528
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.589 ms) : 0, 8589
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.452 ms) : 0, 3452
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/refine-svc-src
git_commit_date 1771808874 1771846029
git_commit_sha d7515c8 1962e89
release_version 1.60.0-SNAPSHOT~d7515c8b3c 1.60.0-SNAPSHOT~1962e89aec
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1771848437 1771848437
ci_job_id 1447057569 1447057569
ci_pipeline_id 98194422 98194422
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-od47r2kk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-od47r2kk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-249.327µs; -113.537µs] or [-8.654%; -3.941%]
better
[-702.313µs; -258.289µs] or [-8.593%; -3.160%]
unstable
[-72.422op/s; +226.360op/s] or [-5.780%; +18.065%]
2.700ms 7.693ms 1330.031op/s 2.881ms 8.173ms 1253.062op/s
scenario:load:petclinic:no_agent:high_load better
[-2.005ms; -0.471ms] or [-10.540%; -2.475%]
unstable
[-3.091ms; +0.100ms] or [-9.928%; +0.321%]
unstable
[-10.714op/s; +42.839op/s] or [-4.470%; +17.875%]
17.782ms 29.643ms 255.719op/s 19.020ms 31.139ms 239.656op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.478 ms) : 19281, 19674
.   : milestone, 19478,
appsec (18.573 ms) : 18382, 18763
.   : milestone, 18573,
code_origins (18.494 ms) : 18306, 18683
.   : milestone, 18494,
iast (17.55 ms) : 17377, 17723
.   : milestone, 17550,
profiling (18.563 ms) : 18377, 18749
.   : milestone, 18563,
tracing (17.593 ms) : 17418, 17768
.   : milestone, 17593,
section candidate
no_agent (18.249 ms) : 18061, 18437
.   : milestone, 18249,
appsec (18.385 ms) : 18202, 18569
.   : milestone, 18385,
code_origins (18.361 ms) : 18177, 18546
.   : milestone, 18361,
iast (17.423 ms) : 17250, 17595
.   : milestone, 17423,
profiling (18.649 ms) : 18464, 18834
.   : milestone, 18649,
tracing (17.776 ms) : 17601, 17952
.   : milestone, 17776,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.478 ms [19.281 ms, 19.674 ms] -
appsec 18.573 ms [18.382 ms, 18.763 ms] -905.123 µs (-4.6%)
code_origins 18.494 ms [18.306 ms, 18.683 ms] -983.363 µs (-5.0%)
iast 17.55 ms [17.377 ms, 17.723 ms] -1.928 ms (-9.9%)
profiling 18.563 ms [18.377 ms, 18.749 ms] -914.748 µs (-4.7%)
tracing 17.593 ms [17.418 ms, 17.768 ms] -1.885 ms (-9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.249 ms [18.061 ms, 18.437 ms] -
appsec 18.385 ms [18.202 ms, 18.569 ms] 136.106 µs (0.7%)
code_origins 18.361 ms [18.177 ms, 18.546 ms] 112.057 µs (0.6%)
iast 17.423 ms [17.25 ms, 17.595 ms] -826.506 µs (-4.5%)
profiling 18.649 ms [18.464 ms, 18.834 ms] 399.538 µs (2.2%)
tracing 17.776 ms [17.601 ms, 17.952 ms] -472.738 µs (-2.6%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
.   : milestone, 1188,
iast (3.166 ms) : 3124, 3208
.   : milestone, 3166,
iast_FULL (5.983 ms) : 5923, 6044
.   : milestone, 5983,
iast_GLOBAL (3.661 ms) : 3600, 3721
.   : milestone, 3661,
profiling (2.173 ms) : 2152, 2194
.   : milestone, 2173,
tracing (1.755 ms) : 1740, 1770
.   : milestone, 1755,
section candidate
no_agent (1.195 ms) : 1183, 1206
.   : milestone, 1195,
iast (3.249 ms) : 3200, 3297
.   : milestone, 3249,
iast_FULL (5.842 ms) : 5783, 5900
.   : milestone, 5842,
iast_GLOBAL (3.446 ms) : 3401, 3491
.   : milestone, 3446,
profiling (2.172 ms) : 2153, 2192
.   : milestone, 2172,
tracing (1.76 ms) : 1745, 1775
.   : milestone, 1760,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.188 ms [1.176 ms, 1.2 ms] -
iast 3.166 ms [3.124 ms, 3.208 ms] 1.978 ms (166.5%)
iast_FULL 5.983 ms [5.923 ms, 6.044 ms] 4.795 ms (403.6%)
iast_GLOBAL 3.661 ms [3.6 ms, 3.721 ms] 2.473 ms (208.1%)
profiling 2.173 ms [2.152 ms, 2.194 ms] 984.536 µs (82.9%)
tracing 1.755 ms [1.74 ms, 1.77 ms] 566.752 µs (47.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.195 ms [1.183 ms, 1.206 ms] -
iast 3.249 ms [3.2 ms, 3.297 ms] 2.054 ms (171.9%)
iast_FULL 5.842 ms [5.783 ms, 5.9 ms] 4.647 ms (388.9%)
iast_GLOBAL 3.446 ms [3.401 ms, 3.491 ms] 2.251 ms (188.4%)
profiling 2.172 ms [2.153 ms, 2.192 ms] 977.366 µs (81.8%)
tracing 1.76 ms [1.745 ms, 1.775 ms] 564.906 µs (47.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/refine-svc-src
git_commit_date 1771808874 1771846029
git_commit_sha d7515c8 1962e89
release_version 1.60.0-SNAPSHOT~d7515c8b3c 1.60.0-SNAPSHOT~1962e89aec
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1771848166 1771848166
ci_job_id 1447057570 1447057570
ci_pipeline_id 98194422 98194422
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-85x4ghmg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-85x4ghmg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.385ms; -1.038ms] or [-36.530%; -27.379%]
2.579ms 3.790ms
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
appsec (14.861 s) : 14861000, 14861000
.   : milestone, 14861000,
iast (18.325 s) : 18325000, 18325000
.   : milestone, 18325000,
iast_GLOBAL (17.798 s) : 17798000, 17798000
.   : milestone, 17798000,
profiling (14.978 s) : 14978000, 14978000
.   : milestone, 14978000,
tracing (14.592 s) : 14592000, 14592000
.   : milestone, 14592000,
section candidate
no_agent (15.319 s) : 15319000, 15319000
.   : milestone, 15319000,
appsec (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
iast (18.328 s) : 18328000, 18328000
.   : milestone, 18328000,
iast_GLOBAL (17.775 s) : 17775000, 17775000
.   : milestone, 17775000,
profiling (15.578 s) : 15578000, 15578000
.   : milestone, 15578000,
tracing (14.61 s) : 14610000, 14610000
.   : milestone, 14610000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.968 s [14.968 s, 14.968 s] -
appsec 14.861 s [14.861 s, 14.861 s] -107.0 ms (-0.7%)
iast 18.325 s [18.325 s, 18.325 s] 3.357 s (22.4%)
iast_GLOBAL 17.798 s [17.798 s, 17.798 s] 2.83 s (18.9%)
profiling 14.978 s [14.978 s, 14.978 s] 10.0 ms (0.1%)
tracing 14.592 s [14.592 s, 14.592 s] -376.0 ms (-2.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.319 s [15.319 s, 15.319 s] -
appsec 15.154 s [15.154 s, 15.154 s] -165.0 ms (-1.1%)
iast 18.328 s [18.328 s, 18.328 s] 3.009 s (19.6%)
iast_GLOBAL 17.775 s [17.775 s, 17.775 s] 2.456 s (16.0%)
profiling 15.578 s [15.578 s, 15.578 s] 259.0 ms (1.7%)
tracing 14.61 s [14.61 s, 14.61 s] -709.0 ms (-4.6%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.79 ms) : 3570, 4011
.   : milestone, 3790,
iast (2.254 ms) : 2185, 2322
.   : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2224, 2362
.   : milestone, 2293,
profiling (2.069 ms) : 2014, 2123
.   : milestone, 2069,
tracing (2.078 ms) : 2024, 2131
.   : milestone, 2078,
section candidate
no_agent (1.474 ms) : 1463, 1485
.   : milestone, 1474,
appsec (2.579 ms) : 2522, 2637
.   : milestone, 2579,
iast (2.255 ms) : 2186, 2323
.   : milestone, 2255,
iast_GLOBAL (2.303 ms) : 2234, 2373
.   : milestone, 2303,
profiling (2.098 ms) : 2042, 2153
.   : milestone, 2098,
tracing (2.068 ms) : 2015, 2121
.   : milestone, 2068,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 3.79 ms [3.57 ms, 4.011 ms] 2.308 ms (155.7%)
iast 2.254 ms [2.185 ms, 2.322 ms] 771.607 µs (52.1%)
iast_GLOBAL 2.293 ms [2.224 ms, 2.362 ms] 810.742 µs (54.7%)
profiling 2.069 ms [2.014 ms, 2.123 ms] 586.274 µs (39.6%)
tracing 2.078 ms [2.024 ms, 2.131 ms] 595.568 µs (40.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.485 ms] -
appsec 2.579 ms [2.522 ms, 2.637 ms] 1.105 ms (75.0%)
iast 2.255 ms [2.186 ms, 2.323 ms] 780.524 µs (53.0%)
iast_GLOBAL 2.303 ms [2.234 ms, 2.373 ms] 829.333 µs (56.3%)
profiling 2.098 ms [2.042 ms, 2.153 ms] 623.716 µs (42.3%)
tracing 2.068 ms [2.015 ms, 2.121 ms] 593.889 µs (40.3%)

Copy link
Copy Markdown
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Feb 23, 2026

View all feedbacks in Devflow UI.

2026-02-23 12:27:43 UTC ℹ️ Start processing command /merge


2026-02-23 12:27:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-02-23 13:56:55 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 8995a31 into master Feb 23, 2026
581 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the andrea.marziali/refine-svc-src branch February 23, 2026 13:56
@github-actions github-actions bot added this to the 1.60.0 milestone Feb 23, 2026
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/dd-trace-go that referenced this pull request Mar 12, 2026
This PR is a first of many that enriches service source to service overrides. In particalar the PR contains:
- introduction of `instrumentation.ServiceNameWithSource` method to be used by all integrations
- 4 integrations covered: grpc, gin-gonic, go-redis, database/sql
- inheritence of service source
- coverage of service mapping configuration
- encoding of source in span.Meta

See other similar PRs in dd-trace-java [PR1 - integration services](DataDog/dd-trace-java#10607),  [PR2- client stats](DataDog/dd-trace-java#10653), [PR3 - config cases](DataDog/dd-trace-java#10658),  [PR4 - manual source](DataDog/dd-trace-java#10704)

<img width="1027" height="655" alt="Screenshot 2026-03-10 at 11 48 36" src="https://github.com/user-attachments/assets/a7db0a35-34cd-4541-bf23-1c8d500af032" />



### Reviewer's Checklist
<!--
* Authors can use this list as a reference to ensure that there are no problems
  during the review but the signing off is to be done by the reviewer(s).
-->

- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag.
- [ ] There is a benchmark for any new code, or changes to existing code.
- [ ] If this interacts with the agent in a new way, a system test has been added.
- [ ] New code is free of linting errors. You can check this by running `make lint` locally.
- [ ] New code doesn't break existing tests. You can check this by running `make test` locally.
- [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [ ] All generated files are up to date. You can check this by running `make generate` locally.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!


Co-authored-by: raphael.gavache <raphael.gavache@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants