In telemetry, replace Objects.hash with HashingUtils.hash#10813
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060865
Total [baseline] (11.082 s) : 0, 11081556
Agent [candidate] (1.063 s) : 0, 1063173
Total [candidate] (11.114 s) : 0, 11113912
section appsec
Agent [baseline] (1.254 s) : 0, 1254153
Total [baseline] (11.209 s) : 0, 11209103
Agent [candidate] (1.252 s) : 0, 1252204
Total [candidate] (11.158 s) : 0, 11157571
section iast
Agent [baseline] (1.233 s) : 0, 1233108
Total [baseline] (11.372 s) : 0, 11372049
Agent [candidate] (1.234 s) : 0, 1233501
Total [candidate] (11.356 s) : 0, 11356325
section profiling
Agent [baseline] (1.188 s) : 0, 1188242
Total [baseline] (10.988 s) : 0, 10987935
Agent [candidate] (1.187 s) : 0, 1186525
Total [candidate] (11.038 s) : 0, 11038231
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (631.116 ms) : 0, 631116
BytebuddyAgent [candidate] (631.017 ms) : 0, 631017
AgentMeter [baseline] (29.393 ms) : 0, 29393
AgentMeter [candidate] (29.497 ms) : 0, 29497
GlobalTracer [baseline] (257.601 ms) : 0, 257601
GlobalTracer [candidate] (257.953 ms) : 0, 257953
AppSec [baseline] (31.862 ms) : 0, 31862
AppSec [candidate] (31.916 ms) : 0, 31916
Debugger [baseline] (60.485 ms) : 0, 60485
Debugger [candidate] (60.737 ms) : 0, 60737
Remote Config [baseline] (598.751 µs) : 0, 599
Remote Config [candidate] (595.743 µs) : 0, 596
Telemetry [baseline] (8.092 ms) : 0, 8092
Telemetry [candidate] (8.85 ms) : 0, 8850
Flare Poller [baseline] (4.306 ms) : 0, 4306
Flare Poller [candidate] (5.174 ms) : 0, 5174
section appsec
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (662.04 ms) : 0, 662040
BytebuddyAgent [candidate] (661.681 ms) : 0, 661681
AgentMeter [baseline] (12.197 ms) : 0, 12197
AgentMeter [candidate] (12.175 ms) : 0, 12175
GlobalTracer [baseline] (259.441 ms) : 0, 259441
GlobalTracer [candidate] (259.028 ms) : 0, 259028
AppSec [baseline] (179.022 ms) : 0, 179022
AppSec [candidate] (178.408 ms) : 0, 178408
Debugger [baseline] (66.046 ms) : 0, 66046
Debugger [candidate] (66.467 ms) : 0, 66467
Remote Config [baseline] (643.695 µs) : 0, 644
Remote Config [candidate] (641.094 µs) : 0, 641
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.351 ms) : 0, 8351
Flare Poller [baseline] (4.441 ms) : 0, 4441
Flare Poller [candidate] (3.605 ms) : 0, 3605
IAST [baseline] (24.285 ms) : 0, 24285
IAST [candidate] (24.286 ms) : 0, 24286
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (799.958 ms) : 0, 799958
BytebuddyAgent [candidate] (799.321 ms) : 0, 799321
AgentMeter [baseline] (11.41 ms) : 0, 11410
AgentMeter [candidate] (11.458 ms) : 0, 11458
GlobalTracer [baseline] (248.275 ms) : 0, 248275
GlobalTracer [candidate] (248.69 ms) : 0, 248690
AppSec [baseline] (26.812 ms) : 0, 26812
AppSec [candidate] (26.645 ms) : 0, 26645
Debugger [baseline] (69.992 ms) : 0, 69992
Debugger [candidate] (70.556 ms) : 0, 70556
Remote Config [baseline] (529.351 µs) : 0, 529
Remote Config [candidate] (536.15 µs) : 0, 536
Telemetry [baseline] (9.675 ms) : 0, 9675
Telemetry [candidate] (9.847 ms) : 0, 9847
Flare Poller [baseline] (3.583 ms) : 0, 3583
Flare Poller [candidate] (3.571 ms) : 0, 3571
IAST [baseline] (25.443 ms) : 0, 25443
IAST [candidate] (25.431 ms) : 0, 25431
section profiling
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (685.943 ms) : 0, 685943
BytebuddyAgent [candidate] (684.999 ms) : 0, 684999
AgentMeter [baseline] (8.98 ms) : 0, 8980
AgentMeter [candidate] (8.949 ms) : 0, 8949
GlobalTracer [baseline] (215.895 ms) : 0, 215895
GlobalTracer [candidate] (215.498 ms) : 0, 215498
AppSec [baseline] (32.415 ms) : 0, 32415
AppSec [candidate] (32.451 ms) : 0, 32451
Debugger [baseline] (66.04 ms) : 0, 66040
Debugger [candidate] (66.167 ms) : 0, 66167
Remote Config [baseline] (573.004 µs) : 0, 573
Remote Config [candidate] (577.662 µs) : 0, 578
Telemetry [baseline] (7.788 ms) : 0, 7788
Telemetry [candidate] (7.767 ms) : 0, 7767
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.528 ms) : 0, 3528
ProfilingAgent [baseline] (94.545 ms) : 0, 94545
ProfilingAgent [candidate] (94.139 ms) : 0, 94139
Profiling [baseline] (95.106 ms) : 0, 95106
Profiling [candidate] (94.703 ms) : 0, 94703
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064875
Total [baseline] (8.864 s) : 0, 8863944
Agent [candidate] (1.06 s) : 0, 1060279
Total [candidate] (8.858 s) : 0, 8857671
section iast
Agent [baseline] (1.238 s) : 0, 1238409
Total [baseline] (9.566 s) : 0, 9566357
Agent [candidate] (1.234 s) : 0, 1233721
Total [candidate] (9.596 s) : 0, 9596081
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (633.169 ms) : 0, 633169
BytebuddyAgent [candidate] (631.11 ms) : 0, 631110
AgentMeter [baseline] (29.557 ms) : 0, 29557
AgentMeter [candidate] (29.401 ms) : 0, 29401
GlobalTracer [baseline] (258.377 ms) : 0, 258377
GlobalTracer [candidate] (257.861 ms) : 0, 257861
AppSec [baseline] (32.011 ms) : 0, 32011
AppSec [candidate] (31.891 ms) : 0, 31891
Debugger [baseline] (59.872 ms) : 0, 59872
Debugger [candidate] (59.698 ms) : 0, 59698
Remote Config [baseline] (588.237 µs) : 0, 588
Remote Config [candidate] (592.048 µs) : 0, 592
Telemetry [baseline] (8.096 ms) : 0, 8096
Telemetry [candidate] (8.07 ms) : 0, 8070
Flare Poller [baseline] (5.739 ms) : 0, 5739
Flare Poller [candidate] (4.305 ms) : 0, 4305
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (806.24 ms) : 0, 806240
BytebuddyAgent [candidate] (800.768 ms) : 0, 800768
AgentMeter [baseline] (11.47 ms) : 0, 11470
AgentMeter [candidate] (11.464 ms) : 0, 11464
GlobalTracer [baseline] (248.428 ms) : 0, 248428
GlobalTracer [candidate] (248.567 ms) : 0, 248567
AppSec [baseline] (26.603 ms) : 0, 26603
AppSec [candidate] (26.659 ms) : 0, 26659
Debugger [baseline] (68.4 ms) : 0, 68400
Debugger [candidate] (69.271 ms) : 0, 69271
Remote Config [baseline] (532.04 µs) : 0, 532
Remote Config [candidate] (538.432 µs) : 0, 538
Telemetry [baseline] (10.128 ms) : 0, 10128
Telemetry [candidate] (9.839 ms) : 0, 9839
Flare Poller [baseline] (3.687 ms) : 0, 3687
Flare Poller [candidate] (3.682 ms) : 0, 3682
IAST [baseline] (25.445 ms) : 0, 25445
IAST [candidate] (25.472 ms) : 0, 25472
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section baseline
no_agent (1.226 ms) : 1214, 1237
. : milestone, 1226,
iast (3.365 ms) : 3318, 3411
. : milestone, 3365,
iast_FULL (6.024 ms) : 5963, 6085
. : milestone, 6024,
iast_GLOBAL (3.673 ms) : 3615, 3732
. : milestone, 3673,
profiling (2.235 ms) : 2215, 2255
. : milestone, 2235,
tracing (1.938 ms) : 1921, 1954
. : milestone, 1938,
section candidate
no_agent (1.226 ms) : 1215, 1237
. : milestone, 1226,
iast (3.296 ms) : 3251, 3341
. : milestone, 3296,
iast_FULL (5.923 ms) : 5863, 5983
. : milestone, 5923,
iast_GLOBAL (3.572 ms) : 3515, 3628
. : milestone, 3572,
profiling (2.259 ms) : 2233, 2284
. : milestone, 2259,
tracing (1.835 ms) : 1820, 1850
. : milestone, 1835,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section baseline
no_agent (18.328 ms) : 18141, 18514
. : milestone, 18328,
appsec (18.462 ms) : 18274, 18650
. : milestone, 18462,
code_origins (18.105 ms) : 17928, 18282
. : milestone, 18105,
iast (17.795 ms) : 17620, 17969
. : milestone, 17795,
profiling (19.672 ms) : 19470, 19873
. : milestone, 19672,
tracing (17.732 ms) : 17556, 17908
. : milestone, 17732,
section candidate
no_agent (18.004 ms) : 17825, 18183
. : milestone, 18004,
appsec (18.492 ms) : 18306, 18677
. : milestone, 18492,
code_origins (17.819 ms) : 17641, 17997
. : milestone, 17819,
iast (18.14 ms) : 17959, 18320
. : milestone, 18140,
profiling (18.669 ms) : 18484, 18854
. : milestone, 18669,
tracing (18.687 ms) : 18503, 18872
. : milestone, 18687,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section baseline
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
iast (18.229 s) : 18229000, 18229000
. : milestone, 18229000,
iast_GLOBAL (17.744 s) : 17744000, 17744000
. : milestone, 17744000,
profiling (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
tracing (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
section candidate
no_agent (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
appsec (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
iast (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
iast_GLOBAL (17.987 s) : 17987000, 17987000
. : milestone, 17987000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3c50c9f978, baseline=1.61.0-SNAPSHOT~cd5bbe11a6
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.747 ms) : 3531, 3964
. : milestone, 3747,
iast (2.268 ms) : 2199, 2336
. : milestone, 2268,
iast_GLOBAL (2.305 ms) : 2236, 2374
. : milestone, 2305,
profiling (2.087 ms) : 2032, 2141
. : milestone, 2087,
tracing (2.066 ms) : 2013, 2119
. : milestone, 2066,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (2.531 ms) : 2476, 2586
. : milestone, 2531,
iast (2.252 ms) : 2183, 2320
. : milestone, 2252,
iast_GLOBAL (2.302 ms) : 2233, 2371
. : milestone, 2302,
profiling (2.1 ms) : 2046, 2155
. : milestone, 2100,
tracing (2.069 ms) : 2015, 2122
. : milestone, 2069,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This PR is rejected because it was updated |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Replaces calls to
Objects.hash()withHashingUtils.hash()in theMetricCollectorto avoidObject[]allocation from var-args call.Motivation
Reduces
Object[]allocation which reduces GC activityAdditional Notes
Updated two
hashCode()method implementations in theMetricCollectorinner classes to useHashingUtils.hash()instead ofObjects.hash().Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issuePR by Bits
View session in Datadog
Comment @DataDog to request changes