Avoid boxing by using TagMap.set in PayloadTagsProcessor#10964
Avoid boxing by using TagMap.set in PayloadTagsProcessor#10964gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057123
Total [baseline] (8.845 s) : 0, 8844741
Agent [candidate] (1.054 s) : 0, 1053842
Total [candidate] (8.861 s) : 0, 8861397
section iast
Agent [baseline] (1.227 s) : 0, 1227126
Total [baseline] (9.556 s) : 0, 9555959
Agent [candidate] (1.226 s) : 0, 1226372
Total [candidate] (9.515 s) : 0, 9515035
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (630.472 ms) : 0, 630472
BytebuddyAgent [candidate] (628.028 ms) : 0, 628028
AgentMeter [baseline] (29.395 ms) : 0, 29395
AgentMeter [candidate] (29.338 ms) : 0, 29338
GlobalTracer [baseline] (256.606 ms) : 0, 256606
GlobalTracer [candidate] (256.154 ms) : 0, 256154
AppSec [baseline] (31.78 ms) : 0, 31780
AppSec [candidate] (31.728 ms) : 0, 31728
Debugger [baseline] (59.482 ms) : 0, 59482
Debugger [candidate] (59.364 ms) : 0, 59364
Remote Config [baseline] (583.498 µs) : 0, 583
Remote Config [candidate] (584.913 µs) : 0, 585
Telemetry [baseline] (8.028 ms) : 0, 8028
Telemetry [candidate] (7.965 ms) : 0, 7965
Flare Poller [baseline] (3.512 ms) : 0, 3512
Flare Poller [candidate] (3.496 ms) : 0, 3496
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (796.335 ms) : 0, 796335
BytebuddyAgent [candidate] (795.639 ms) : 0, 795639
AgentMeter [baseline] (11.421 ms) : 0, 11421
AgentMeter [candidate] (11.426 ms) : 0, 11426
GlobalTracer [baseline] (247.276 ms) : 0, 247276
GlobalTracer [candidate] (246.993 ms) : 0, 246993
AppSec [baseline] (26.546 ms) : 0, 26546
AppSec [candidate] (26.622 ms) : 0, 26622
Debugger [baseline] (69.851 ms) : 0, 69851
Debugger [candidate] (69.307 ms) : 0, 69307
Remote Config [baseline] (547.001 µs) : 0, 547
Remote Config [candidate] (527.639 µs) : 0, 528
Telemetry [baseline] (9.171 ms) : 0, 9171
Telemetry [candidate] (9.664 ms) : 0, 9664
Flare Poller [baseline] (3.382 ms) : 0, 3382
Flare Poller [candidate] (3.577 ms) : 0, 3577
IAST [baseline] (25.394 ms) : 0, 25394
IAST [candidate] (25.37 ms) : 0, 25370
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058104
Total [baseline] (11.083 s) : 0, 11083042
Agent [candidate] (1.064 s) : 0, 1064107
Total [candidate] (11.072 s) : 0, 11072295
section appsec
Agent [baseline] (1.25 s) : 0, 1250334
Total [baseline] (11.141 s) : 0, 11140964
Agent [candidate] (1.254 s) : 0, 1254485
Total [candidate] (11.157 s) : 0, 11157165
section iast
Agent [baseline] (1.229 s) : 0, 1228548
Total [baseline] (11.331 s) : 0, 11330811
Agent [candidate] (1.229 s) : 0, 1229133
Total [candidate] (11.246 s) : 0, 11246071
section profiling
Agent [baseline] (1.182 s) : 0, 1181772
Total [baseline] (10.972 s) : 0, 10972357
Agent [candidate] (1.197 s) : 0, 1197112
Total [candidate] (11.17 s) : 0, 11169953
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (627.986 ms) : 0, 627986
BytebuddyAgent [candidate] (633.053 ms) : 0, 633053
AgentMeter [baseline] (29.36 ms) : 0, 29360
AgentMeter [candidate] (29.659 ms) : 0, 29659
GlobalTracer [baseline] (256.432 ms) : 0, 256432
GlobalTracer [candidate] (258.397 ms) : 0, 258397
AppSec [baseline] (31.709 ms) : 0, 31709
AppSec [candidate] (32.06 ms) : 0, 32060
Debugger [baseline] (60.16 ms) : 0, 60160
Debugger [candidate] (60.577 ms) : 0, 60577
Remote Config [baseline] (584.233 µs) : 0, 584
Remote Config [candidate] (586.855 µs) : 0, 587
Telemetry [baseline] (8.082 ms) : 0, 8082
Telemetry [candidate] (8.136 ms) : 0, 8136
Flare Poller [baseline] (6.567 ms) : 0, 6567
Flare Poller [candidate] (4.349 ms) : 0, 4349
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (661.124 ms) : 0, 661124
BytebuddyAgent [candidate] (663.782 ms) : 0, 663782
AgentMeter [baseline] (12.163 ms) : 0, 12163
AgentMeter [candidate] (12.204 ms) : 0, 12204
GlobalTracer [baseline] (258.532 ms) : 0, 258532
GlobalTracer [candidate] (259.233 ms) : 0, 259233
AppSec [baseline] (177.766 ms) : 0, 177766
AppSec [candidate] (177.967 ms) : 0, 177967
Debugger [baseline] (66.66 ms) : 0, 66660
Debugger [candidate] (66.676 ms) : 0, 66676
Remote Config [baseline] (622.206 µs) : 0, 622
Remote Config [candidate] (640.556 µs) : 0, 641
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.401 ms) : 0, 8401
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (3.623 ms) : 0, 3623
IAST [baseline] (24.221 ms) : 0, 24221
IAST [candidate] (24.396 ms) : 0, 24396
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (796.614 ms) : 0, 796614
BytebuddyAgent [candidate] (797.31 ms) : 0, 797310
AgentMeter [baseline] (11.418 ms) : 0, 11418
AgentMeter [candidate] (11.439 ms) : 0, 11439
GlobalTracer [baseline] (247.151 ms) : 0, 247151
GlobalTracer [candidate] (247.568 ms) : 0, 247568
AppSec [baseline] (26.556 ms) : 0, 26556
AppSec [candidate] (26.514 ms) : 0, 26514
Debugger [baseline] (70.885 ms) : 0, 70885
Debugger [candidate] (70.718 ms) : 0, 70718
Remote Config [baseline] (531.568 µs) : 0, 532
Remote Config [candidate] (522.049 µs) : 0, 522
Telemetry [baseline] (9.275 ms) : 0, 9275
Telemetry [candidate] (9.163 ms) : 0, 9163
Flare Poller [baseline] (3.427 ms) : 0, 3427
Flare Poller [candidate] (3.313 ms) : 0, 3313
IAST [baseline] (25.4 ms) : 0, 25400
IAST [candidate] (25.318 ms) : 0, 25318
section profiling
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (683.182 ms) : 0, 683182
BytebuddyAgent [candidate] (691.652 ms) : 0, 691652
AgentMeter [baseline] (8.984 ms) : 0, 8984
AgentMeter [candidate] (9.079 ms) : 0, 9079
GlobalTracer [baseline] (214.225 ms) : 0, 214225
GlobalTracer [candidate] (217.524 ms) : 0, 217524
AppSec [baseline] (32.177 ms) : 0, 32177
AppSec [candidate] (32.715 ms) : 0, 32715
Debugger [baseline] (65.238 ms) : 0, 65238
Debugger [candidate] (66.713 ms) : 0, 66713
Remote Config [baseline] (563.824 µs) : 0, 564
Remote Config [candidate] (580.465 µs) : 0, 580
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (7.879 ms) : 0, 7879
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.574 ms) : 0, 3574
ProfilingAgent [baseline] (93.474 ms) : 0, 93474
ProfilingAgent [candidate] (94.919 ms) : 0, 94919
Profiling [baseline] (94.03 ms) : 0, 94030
Profiling [candidate] (95.485 ms) : 0, 95485
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.265 ms) : 3221, 3309
. : milestone, 3265,
iast_FULL (5.995 ms) : 5934, 6056
. : milestone, 5995,
iast_GLOBAL (3.486 ms) : 3432, 3539
. : milestone, 3486,
profiling (2.247 ms) : 2226, 2268
. : milestone, 2247,
tracing (1.774 ms) : 1759, 1789
. : milestone, 1774,
section candidate
no_agent (1.171 ms) : 1160, 1181
. : milestone, 1171,
iast (3.281 ms) : 3236, 3325
. : milestone, 3281,
iast_FULL (5.875 ms) : 5816, 5934
. : milestone, 5875,
iast_GLOBAL (3.369 ms) : 3324, 3415
. : milestone, 3369,
profiling (2.242 ms) : 2221, 2263
. : milestone, 2242,
tracing (1.798 ms) : 1784, 1813
. : milestone, 1798,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (19.362 ms) : 19170, 19555
. : milestone, 19362,
appsec (19.609 ms) : 19410, 19807
. : milestone, 19609,
code_origins (17.797 ms) : 17623, 17972
. : milestone, 17797,
iast (18.188 ms) : 18007, 18369
. : milestone, 18188,
profiling (18.867 ms) : 18679, 19055
. : milestone, 18867,
tracing (17.555 ms) : 17381, 17729
. : milestone, 17555,
section candidate
no_agent (19.194 ms) : 19003, 19385
. : milestone, 19194,
appsec (18.779 ms) : 18588, 18971
. : milestone, 18779,
code_origins (17.785 ms) : 17607, 17963
. : milestone, 17785,
iast (18.206 ms) : 18023, 18389
. : milestone, 18206,
profiling (18.899 ms) : 18708, 19090
. : milestone, 18899,
tracing (17.911 ms) : 17732, 18089
. : milestone, 17911,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.817 ms) : 3594, 4040
. : milestone, 3817,
iast (2.266 ms) : 2197, 2335
. : milestone, 2266,
iast_GLOBAL (2.312 ms) : 2242, 2382
. : milestone, 2312,
profiling (2.101 ms) : 2045, 2156
. : milestone, 2101,
tracing (2.068 ms) : 2014, 2122
. : milestone, 2068,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.833 ms) : 3610, 4055
. : milestone, 3833,
iast (2.259 ms) : 2190, 2328
. : milestone, 2259,
iast_GLOBAL (2.306 ms) : 2236, 2375
. : milestone, 2306,
profiling (2.534 ms) : 2316, 2752
. : milestone, 2534,
tracing (2.08 ms) : 2026, 2134
. : milestone, 2080,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~cd32a10995, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (15.46 s) : 15460000, 15460000
. : milestone, 15460000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.036 s) : 18036000, 18036000
. : milestone, 18036000,
iast_GLOBAL (18.106 s) : 18106000, 18106000
. : milestone, 18106000,
profiling (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
section candidate
no_agent (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.54 s) : 18540000, 18540000
. : milestone, 18540000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
tracing (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
9fd98dd
into
master
What Does This Do
Replaces TagMap.put calls with TagMap.set calls.
Motivation
TagMap.set avoids primitive boxing - reducing allocation & GC
Additional Notes
Jira ticket: APMLP-1149
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issuePR by Bits - View session in Datadog
Comment @DataDog to request changes