Skip to content

Fix capture limit for capture expressions#11042

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
jpbempel/fix-inherited-capture-limits
Apr 2, 2026
Merged

Fix capture limit for capture expressions#11042
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
jpbempel/fix-inherited-capture-limits

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Apr 2, 2026

What Does This Do

if we set a capture at probe level and no capture for capture expressions, each capture expression should apply the the capture limits defined at probe level.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-5389

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

if we set a capture at probe level and no capture for capture
expressions, each capture expression should apply the the capture
limits defined at probe level.
@jpbempel jpbempel requested a review from a team as a code owner April 2, 2026 15:45
@jpbempel jpbempel requested review from evanchooly and removed request for a team April 2, 2026 15:45
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added the type: bug Bug report and fix label Apr 2, 2026
Copy link
Copy Markdown
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpbempel
Copy link
Copy Markdown
Member Author

jpbempel commented Apr 2, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026

View all feedbacks in Devflow UI.

2026-04-02 17:38:27 UTC ℹ️ Start processing command /merge


2026-04-02 17:38:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-04-02 18:38:13 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit ca975c2 into master Apr 2, 2026
751 of 759 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the jpbempel/fix-inherited-capture-limits branch April 2, 2026 18:38
@github-actions github-actions bot added this to the 1.61.0 milestone Apr 2, 2026
@PerfectSlayer PerfectSlayer changed the title fix capture limit for capture expressions Fix capture limit for capture expressions Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants