fix: Merge sidebar options maintaining original values#157
Merged
Sidnioulz merged 2 commits intoSidnioulz:mainfrom Mar 19, 2026
Merged
fix: Merge sidebar options maintaining original values#157Sidnioulz merged 2 commits intoSidnioulz:mainfrom
Sidnioulz merged 2 commits intoSidnioulz:mainfrom
Conversation
aduth
commented
Mar 11, 2026
Sidnioulz
approved these changes
Mar 19, 2026
Sidnioulz
force-pushed
the
fix/sidebar-merge
branch
from
e3622ba to
be42845
Compare
Owner
|
Thank you for your contribution @aduth! Much appreciated! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage ? 66.25%
=======================================
Files ? 22
Lines ? 326
Branches ? 115
=======================================
Hits ? 216
Misses ? 98
Partials ? 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Steve Dodier-Lazaro <sidnioulz@gmail.com>
Signed-off-by: Steve Dodier-Lazaro <sidnioulz@gmail.com>
Sidnioulz
force-pushed
the
fix/sidebar-merge
branch
from
be42845 to
8ad38bc
Compare
|
|
🎉 This PR is included in version 3.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150
Updates config handling to maintain user-specified
sidebaroptions.addons.setConfigperforms a shallow merge, so passing an object that contains onlyrenderLabelmeans that any other options specified by downstream consumers (e.g.showRoots, etc.) would be discarded.The changes proposed here maintain the expected defaulting
renderLabelbehavior while also carrying forward any other sidebar settings.