Interactivity: Make Window.scheduler required to match DOM lib#76271
Merged
manzoorwanijk merged 1 commit intotrunkfrom Mar 8, 2026
Merged
Interactivity: Make Window.scheduler required to match DOM lib#76271manzoorwanijk merged 1 commit intotrunkfrom
Window.scheduler required to match DOM lib#76271manzoorwanijk merged 1 commit intotrunkfrom
Conversation
The previous fix added `postTask` but kept `scheduler` optional. The DOM lib declares `scheduler` as required on `WindowOrWorkerGlobalScope`, so the optional declaration still causes TS2430 in downstream projects that augment Window.
manzoorwanijk
added
the
[Type] Bug
1 task
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 8, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dsas
added
the
[Feature] Interactivity API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #76070
Make the
Window.scheduleraugmentation required (non-optional) to match the DOM lib'sWindowOrWorkerGlobalScope.schedulerdeclaration.Why?
#76070 fixed the missing
postTaskmember but keptscheduleras optional (scheduler?). The DOM lib declaresscheduleras required onWindowOrWorkerGlobalScope:Our augmentation still marks it optional:
This mismatch can still trigger TS2430 in downstream projects that augment
Window, because the optional declaration is incompatible with the required inherited property fromWindowOrWorkerGlobalScope.How?
Remove the
?fromschedulerin the globalWindowaugmentation so it matches the DOM lib:declare global { interface Window { - scheduler?: { + scheduler: { postTask: ( ... ) => Promise< unknown >; yield: () => Promise< void >; }; } }The existing runtime guard (
typeof window.scheduler?.yield === 'function') remains unchanged and safely handles browsers whereyieldis not yet implemented.Testing Instructions
@wordpress/interactivityas a dependency in a TypeScript project configured withlib: ["dom"](TypeScript 5.5+ ortsgo)..tsfile, add a globalWindowaugmentation:tsc --noEmit.TS2430error is reported.Testing Instructions for Keyboard
N/A — this is a type-only change with no UI impact.