Site Tagline: Fix block error when migrating deprecated textAlign attribute#76821
Merged
Site Tagline: Fix block error when migrating deprecated textAlign attribute#76821
Conversation
…ribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 7.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 612f6f4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23583990863
|
Contributor
Author
|
@shimotmk Thanks for the review! |
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 26, 2026
…ribute (#76821) * Site Tagline: Fix block error when migrating deprecated textAlign attribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update fixture --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
…ribute (#76821) * Site Tagline: Fix block error when migrating deprecated textAlign attribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update fixture --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ribute (#76821) * Site Tagline: Fix block error when migrating deprecated textAlign attribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update fixture --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #75690
What?
Fix a React error (
<hundefined>) in the Site Tagline block when it contains the deprecatedtextAlignattribute.Why?
When a Site Tagline block with the old
textAlignattribute (e.g.<!-- wp:site-tagline {"textAlign":"center"} /-->) is parsed through the v2 deprecation path, thelevelattribute remainsundefinedbecause itsdefault: 0was missing from the deprecated definition. This causesh${undefined}→hundefinedto be rendered as a tag name, triggering a React error.How?
Added the missing
default: 0for thelevelattribute in the v2 deprecated block definition.Testing Instructions
<!-- wp:site-tagline {"textAlign":"center"} /-->Screenshot
Before
ba468e67260a76ed5be2169c7daa3b00.mp4
After
a35ee0df30fa681f79a807e9c4c4c365.mp4
Use of AI Tools
Claude Code was used to assist with investigating the root cause and authoring this fix.