Conversation
|
Size Change: 0 B Total Size: 7.73 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 87ca58c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23851126857
|
| id: 'excerpt', | ||
| layout: { | ||
| type: 'panel', | ||
| labelPosition: 'top', |
There was a problem hiding this comment.
Perhaps labelPosition: none could also work.
There was a problem hiding this comment.
I had tried that in the original PR.
If we apply the panel layout for excerpt without a label and updating the value of the field to a placeholder like text (like Add an excerpt) is closer to what we have in trunk without the experiment but the problem is there is no clear indication that this field is an excerpt. In trunk we show an edit excerpt button below which is clear. This needs input from @WordPress/gutenberg-design
I can update if there is any new design feedback.
There was a problem hiding this comment.
This might be a controversial take but I don't mind the label. I agree it's unclear what the excerpt is without one.
Either way this feels like a detail to work out separately with wider design feedback, and shouldn't hold up this PR.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
99760d8 to
87ca58c
Compare
What?
Follow up of: #76829
See: #76829 (comment)
This PR tweaks a bit the
excerptfield design under the Editor Inspector: Use DataForm experiment.Testing Instructions