Thumbnails not converted to webp since update 1.2.0

[Joaojack]

Hello, since update 1.2.0, my different thumbnail sizes are not automatically converted to webp. The options are still checked in settings, and it worked before.

I'm using Real Thumbnail Generator to generate several thumbnails on each upload, and it worked fine with performance.

[Joaojack]

My original picture is correctly converted (apple.webp), but the generated thumbnails (apple-large.jpg, apple-thumbnail.jpg) were not

[Joaojack]

@mukeshpanchal27 if you need any precisions on my issue don't hesitate to ask me, thanks !

[mukeshpanchal27]

@Joaojack Thanks for reporting the bug. I recreated it in the 1.2.0 version using the free Real Thumbnail Generator plugin and the Regenerate Thumbnails plugin.

It was related to Avoid overwriting existing WebP files when creating WebP images.

cc @felixarntz 

[felixarntz]

@mukeshpanchal27 @Joaojack I left a reply in #422 (comment), this issue definitely needs some further thought. We cannot risk overwriting files that may be used in other images, so as long as we are unable to know whether an existing file belonged to the same attachment, we cannot move forward here. Unfortunately there is no straightforward fix for this which wouldn't introduce a bug that's worse than this one.

I'm still curious why the old sources aren't available when regenerating files for an image. Do the regenerate images plugins completely delete the image's attachment metadata before regenerating files for it? 🤔

[Joaojack]

Bu why did it work before ? Le mer. 13 juil. 2022 à 20:54, Felix Arntz ***@***.***> a écrit :

…

@mukeshpanchal27 <https://github.com/mukeshpanchal27> @Joaojack <https://github.com/Joaojack> I left a reply in #422 (comment) <#422 (comment)>, this issue definitely needs some further thought. We cannot risk overwriting files that may be used in other images, so as long as we are unable to know whether an existing file belonged to the same attachment, we cannot move forward here. Unfortunately there is no straightforward fix for this which wouldn't introduce a bug that's worse than this one. I'm still curious why the old sources aren't available when regenerating files for an image. Do the regenerate images plugins completely delete the image's attachment metadata before regenerating files for it? 🤔 — Reply to this email directly, view it on GitHub <#395 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMPASY6OZLYMLWIKXSWOO5LVT4GHJANCNFSM5Z6Y7ELA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[felixarntz]

@Joaojack Before there was another bug #359, and when that was fixed, we introduced the bug you encountered here. The problem of addressing both bugs at the same time is quite complex, so this will require more exploration from an engineering perspective.

While the bug in #359 is quite specific, it unfortunately is the more severe bug (accidentally mixing up image files with another attachment), so we also cannot just revert the fix.

We will have to look into this problem further.

[Joaojack]

Thank you @felixarntz for this answer. Is there any way for me to download the previous version ? I've developed a whole vue frontend calling webp versions for each thumbnail and everything is broken since the update.