Skip to content

[secrity](auth) Add x509 cert based auth framework#60098

Merged
gavinchou merged 2 commits intoapache:masterfrom
Hastyshell:pick-master-tls-auth
Feb 3, 2026
Merged

[secrity](auth) Add x509 cert based auth framework#60098
gavinchou merged 2 commits intoapache:masterfrom
Hastyshell:pick-master-tls-auth

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

@Hastyshell Hastyshell commented Jan 21, 2026 •
edited by gavinchou
Loading

No description provided.

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Jan 21, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou gavinchou changed the title [chore](cherry-pick) Pick cert based auth DDL and RPC fields [secrity](auth) Add x509 cert based auth framework Jan 21, 2026
@Hastyshell Hastyshell force-pushed the pick-master-tls-auth branch from 3c56f7c to 121f346 Compare January 21, 2026 07:32
@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Jan 21, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 21, 2026

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.52% (1786/2246)
Line Coverage 64.75% (31802/49114)
Region Coverage 65.48% (15848/24201)
Branch Coverage 56.01% (8417/15028)

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 21, 2026

FE UT Coverage Report

Increment line coverage 30.73% (55/179) 🎉
Increment coverage report
Complete coverage report

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Jan 21, 2026

run feut

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jan 21, 2026

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.40% (19048/36353)
Line Coverage 35.70% (176470/494251)
Region Coverage 32.24% (136630/423779)
Branch Coverage 33.14% (59086/178267)

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 21, 2026

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.03% (26021/35632)
Line Coverage 56.02% (276579/493697)
Region Coverage 53.79% (230373/428285)
Branch Coverage 55.50% (99361/179030)

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 21, 2026

FE Regression Coverage Report

Increment line coverage 14.53% (26/179) 🎉
Increment coverage report
Complete coverage report

gavinchou
gavinchou previously approved these changes Jan 21, 2026
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 23, 2026
@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Jan 27, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 27, 2026

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.32% (1787/2253)
Line Coverage 64.76% (31821/49139)
Region Coverage 65.50% (15870/24228)
Branch Coverage 56.04% (8430/15042)

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jan 27, 2026

TPC-H: Total hot run time: 32576 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be28ed27d1484eaf111d8687bef57f80cef8cce3, data reload: false

------ Round 1 ----------------------------------
q1	17667	5229	5095	5095
q2	2009	316	199	199
q3	10576	1342	735	735
q4	10340	799	319	319
q5	9828	2211	1888	1888
q6	259	179	148	148
q7	893	746	598	598
q8	9273	1382	1110	1110
q9	5567	4844	4947	4844
q10	6864	1964	1560	1560
q11	514	278	274	274
q12	391	379	223	223
q13	17823	4123	3240	3240
q14	241	234	217	217
q15	920	863	816	816
q16	690	674	619	619
q17	653	832	496	496
q18	6757	6572	6453	6453
q19	1145	993	637	637
q20	396	350	233	233
q21	2623	2034	1906	1906
q22	1053	1006	966	966
Total cold run time: 106482 ms
Total hot run time: 32576 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5400	5291	5302	5291
q2	255	362	250	250
q3	2181	2689	2264	2264
q4	1366	1761	1330	1330
q5	4259	4162	4980	4162
q6	235	196	144	144
q7	2087	1992	1800	1800
q8	2559	2501	2357	2357
q9	7527	7418	7526	7418
q10	2891	3006	2590	2590
q11	545	498	475	475
q12	682	799	710	710
q13	4198	4398	3598	3598
q14	297	302	275	275
q15	893	867	838	838
q16	737	768	759	759
q17	1132	1284	1285	1284
q18	8187	8151	8012	8012
q19	887	808	829	808
q20	2078	2217	2070	2070
q21	4548	4257	4128	4128
q22	1110	1047	953	953
Total cold run time: 54054 ms
Total hot run time: 51516 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jan 27, 2026

ClickBench: Total hot run time: 27.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be28ed27d1484eaf111d8687bef57f80cef8cce3, data reload: false

query1	0.06	0.05	0.05
query2	0.14	0.06	0.06
query3	0.32	0.08	0.08
query4	1.65	0.11	0.10
query5	0.27	0.26	0.25
query6	1.13	0.66	0.64
query7	0.04	0.03	0.03
query8	0.08	0.06	0.07
query9	0.60	0.51	0.50
query10	0.55	0.55	0.56
query11	0.25	0.14	0.13
query12	0.26	0.14	0.14
query13	0.62	0.63	0.61
query14	0.99	0.99	0.97
query15	0.89	0.82	0.81
query16	0.40	0.39	0.39
query17	1.08	1.07	1.03
query18	0.24	0.22	0.22
query19	1.96	1.82	1.85
query20	0.03	0.01	0.02
query21	15.40	0.28	0.23
query22	4.98	0.09	0.10
query23	15.42	0.39	0.23
query24	2.53	0.49	0.34
query25	0.11	0.10	0.09
query26	0.18	0.17	0.17
query27	0.09	0.08	0.09
query28	3.74	1.12	0.95
query29	12.50	4.05	3.25
query30	0.32	0.13	0.12
query31	2.79	0.64	0.42
query32	3.25	0.61	0.49
query33	3.08	2.99	3.08
query34	16.10	5.13	4.45
query35	4.41	4.48	4.43
query36	0.62	0.50	0.47
query37	0.27	0.08	0.08
query38	0.20	0.05	0.06
query39	0.08	0.05	0.05
query40	0.20	0.18	0.17
query41	0.13	0.06	0.06
query42	0.07	0.05	0.05
query43	0.07	0.07	0.06
Total cold run time: 98.1 s
Total hot run time: 27.77 s

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 27, 2026

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.49% (19160/36501)
Line Coverage 35.89% (178226/496534)
Region Coverage 32.37% (137865/425944)
Branch Coverage 33.29% (59658/179195)

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 27, 2026

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.15% (26173/35778)
Line Coverage 56.26% (279031/495990)
Region Coverage 54.00% (232459/430449)
Branch Coverage 55.65% (100142/179963)

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Increment line coverage 17.32% (31/179) 🎉
Increment coverage report
Complete coverage report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 3, 2026
@gavinchou gavinchou merged commit d78ad3e into apache:master Feb 3, 2026
29 of 31 checks passed
Hastyshell added a commit to Hastyshell/doris that referenced this pull request Feb 3, 2026
@Hastyshell
[secrity](auth) Add x509 cert based auth framework (apache#60098)
3c7faf4
yiguolei pushed a commit that referenced this pull request Feb 4, 2026
@Hastyshell
[secrity](auth) Add x509 cert based auth framework (#60098) (#60469)
d93e92b 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
ybtsdst pushed a commit to ybtsdst/doris that referenced this pull request Feb 27, 2026
@Hastyshell
[secrity](auth) Add x509 cert based auth framework (apache#60098) (ap…
c87fb55 
…ache#60469)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei yiguolei mentioned this pull request Mar 7, 2026
Open
@Hastyshell Hastyshell deleted the pick-master-tls-auth branch March 30, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@luwei16 luwei16 luwei16 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hastyshell @Thearas @hello-stephen @doris-robot @gavinchou @luwei16