Skip to content

branch-4.1: [fix](iceberg) Avoid dict reads on mixed-encoding position delete files #61759#62136

Merged
yiguolei merged 6 commits intoapache:branch-4.1from
suxiaogang223:codex/fix-62036-runtime-state
Apr 8, 2026
Merged

branch-4.1: [fix](iceberg) Avoid dict reads on mixed-encoding position delete files #61759#62136
yiguolei merged 6 commits intoapache:branch-4.1from
suxiaogang223:codex/fix-62036-runtime-state

Conversation

@suxiaogang223
Copy link
Copy Markdown
Contributor

Cherry-picked from #61759

### What problem does this PR solve?\n\nIssue Number: None\nRelated PR: apache#62036\nProblem Summary: The auto-pick branch added BE tests that used the removed RuntimeState(TQueryOptions, TQueryGlobals) constructor, causing BE UT compilation to fail. This patch keeps the mixed-encoding position delete fix and adjusts the test to the current RuntimeState constructor.\n\n### Release note\n\nNone\n\n### Check List (For Author)\n\n- Test: Not run (per request)\n    - No need to test\n- Behavior changed: No\n- Does this need documentation: No
@suxiaogang223 suxiaogang223 requested a review from yiguolei as a code owner April 6, 2026 10:36
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223 suxiaogang223 force-pushed the codex/fix-62036-runtime-state branch from 2e03c47 to c0da19e Compare April 6, 2026 10:39
@suxiaogang223
Copy link
Copy Markdown
Contributor Author

run buildall

@suxiaogang223 suxiaogang223 force-pushed the codex/fix-62036-runtime-state branch from c0da19e to 92130ad Compare April 6, 2026 11:38
@suxiaogang223
Copy link
Copy Markdown
Contributor Author

run buildall

### What problem does this PR solve?\n\nIssue Number: None\nRelated PR: apache#62036\nProblem Summary: The Iceberg reader test used a parenthesized RuntimeState initialization that was parsed as a function declaration, causing BE test compilation to fail. This follow-up uses brace initialization so the test constructs a RuntimeState object correctly.\n\n### Release note\n\nNone\n\n### Check List (For Author)\n\n- Test: Not run (per request)\n    - No need to test\n- Behavior changed: No\n- Does this need documentation: No
@suxiaogang223
Copy link
Copy Markdown
Contributor Author

run buildall

### What problem does this PR solve?\n\nIssue Number: None\nRelated PR: apache#62036\nProblem Summary: The replacement branch for the Iceberg mixed-encoding delete-file fix was missing the parquet test data file from the original master commit, causing the new BE unit tests to fail with file-not-found errors. This follow-up restores the original test asset.\n\n### Release note\n\nNone\n\n### Check List (For Author)\n\n- Test: Not run (per request)\n    - No need to test\n- Behavior changed: No\n- Does this need documentation: No
@suxiaogang223
Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 97.73% (43/44) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.99% (19840/37439)
Line Coverage 36.51% (186663/511223)
Region Coverage 32.85% (144972/441300)
Branch Coverage 33.96% (63509/187000)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 97.65% (166/170) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.37% (26154/36647)
Line Coverage 54.29% (276618/509526)
Region Coverage 51.60% (229757/445264)
Branch Coverage 53.00% (99385/187530)

@yiguolei yiguolei merged commit 0785015 into apache:branch-4.1 Apr 8, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants