Skip to content

[Bug] fix insert load should have the same behavior as stream load#7180

Closed
spaces-X wants to merge 3 commits intoapache:masterfrom
spaces-X:insert_filtered_max
Closed

[Bug] fix insert load should have the same behavior as stream load#7180
spaces-X wants to merge 3 commits intoapache:masterfrom
spaces-X:insert_filtered_max

Conversation

@spaces-X
Copy link
Copy Markdown
Contributor

@spaces-X spaces-X commented Nov 22, 2021

Proposed changes

see #7179

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman reviewed Nov 23, 2021
View reviewed changes
morningman
morningman reviewed Dec 1, 2021
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java Outdated
public long loadMemLimit = 0L;

@VariableMgr.VarAttr(name = INSERT_MAX_FILTER_RATIO)
public double insertMaxFilterRatio = 0L;
Copy link
Copy Markdown
Contributor

@morningman morningman Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be 1.0, to be same as origin.
and please update the document:

docs/zh-CN/administrator-guide/variables.md
docs/en/administrator-guide/variables.md

Copy link
Copy Markdown
Contributor Author

@spaces-X spaces-X Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@spaces-X spaces-X force-pushed the insert_filtered_max branch from 6fcd7f6 to 65853d1 Compare December 24, 2021 04:44
@spaces-X spaces-X closed this Feb 11, 2022
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Feb 10, 2026
@airborne12
[fix](search) Fix REGEXP lowercase, variant subcolumn index_propertie…
ab8c7e0 
…s, and lower_case defaults

Cherry-picked from jk-selectdb/hubspot branch (3 commits):

1. REGEXP lowercase fix (apache#7224): REGEXP patterns in search() are no longer
   lowercased, matching ES query_string behavior where regex queries match
   directly against the term dictionary without normalization. WILDCARD/PREFIX
   patterns are still lowercased.

2. Variant subcolumn index_properties: Pass index_properties from FE to BE
   via TSearchFieldBinding so variant subcolumn field_pattern indexes can
   resolve correct analyzer settings.

3. lower_case default fix (apache#7152, apache#7180): Only add lower_case=true default
   for built-in analyzers in to_schema_pb, not for custom analyzers where
   lowercase behavior is determined by the analyzer's internal token filter.

Test: 113 SearchDslParser UTs + 12 SearchPredicateTest UTs pass.
      5 existing search regression tests pass.
      test_search_variant_subcolumn_analyzer regression test passes.
      test_search_regexp_lowercase needs BE rebuild to pass (FE-only deploy).
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Feb 10, 2026
@airborne12
[fix](search) Fix REGEXP lowercase, variant subcolumn index_propertie…
a0ec3f8 
…s, and lower_case defaults

Cherry-picked from jk-selectdb/hubspot branch (3 commits):

1. REGEXP lowercase fix (apache#7224): REGEXP patterns in search() are no longer
   lowercased, matching ES query_string behavior where regex queries match
   directly against the term dictionary without normalization. WILDCARD/PREFIX
   patterns are still lowercased.

2. Variant subcolumn index_properties: Pass index_properties from FE to BE
   via TSearchFieldBinding so variant subcolumn field_pattern indexes can
   resolve correct analyzer settings.

3. lower_case default fix (apache#7152, apache#7180): Only add lower_case=true default
   for built-in analyzers in to_schema_pb, not for custom analyzers where
   lowercase behavior is determined by the analyzer's internal token filter.

Test: 113 SearchDslParser UTs + 12 SearchPredicateTest UTs pass.
      5 existing search regression tests pass.
      test_search_variant_subcolumn_analyzer regression test passes.
      test_search_regexp_lowercase needs BE rebuild to pass (FE-only deploy).
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Feb 17, 2026
@airborne12
[fix](search) Fix REGEXP lowercase, variant subcolumn index_propertie…
e19aa4f 
…s, and lower_case defaults

Cherry-picked from jk-selectdb/hubspot branch (3 commits):

1. REGEXP lowercase fix (apache#7224): REGEXP patterns in search() are no longer
   lowercased, matching ES query_string behavior where regex queries match
   directly against the term dictionary without normalization. WILDCARD/PREFIX
   patterns are still lowercased.

2. Variant subcolumn index_properties: Pass index_properties from FE to BE
   via TSearchFieldBinding so variant subcolumn field_pattern indexes can
   resolve correct analyzer settings.

3. lower_case default fix (apache#7152, apache#7180): Only add lower_case=true default
   for built-in analyzers in to_schema_pb, not for custom analyzers where
   lowercase behavior is determined by the analyzer's internal token filter.

Test: 113 SearchDslParser UTs + 12 SearchPredicateTest UTs pass.
      5 existing search regression tests pass.
      test_search_variant_subcolumn_analyzer regression test passes.
      test_search_regexp_lowercase needs BE rebuild to pass (FE-only deploy).
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Feb 27, 2026
@airborne12 @claude
[fix](inverted-index) Only add lower_case default for built-in analyz…
b4ebe5c 
…ers in to_schema_pb (apache#7180)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spaces-X @morningman