Skip to content

OAL tool module established#2015

Merged
wu-sheng merged 11 commits intomasterfrom
oal-tool-movein
Dec 7, 2018
Merged

OAL tool module established#2015
wu-sheng merged 11 commits intomasterfrom
oal-tool-movein

Conversation

@wu-sheng
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng commented Dec 6, 2018

  1. [PR [OAL refactor step 1]Refactor dispatcher manager #2006] Make hard codes in DispatcherManager goes away.
  2. [In this PR] Move genereated package to an maven module(a.k.a. a jar in oal-libs), named generated-analysis
  3. [In this PR] Move the oal-tool back into the main repo, and could generate codes during mvn compile.

@wu-sheng
Copy link
Copy Markdown
Member Author

wu-sheng commented Dec 6, 2018

The oap-server/generate-tool module includes the source codes of compiling tool. This tool is already integrated
maven compile phase. So, unless you want to change the tool source codes, you don't need to set anything.

Run ./mvnw compile or ./mvnw package, the generated codes of the oal script are in oap-server/generate-tool/target/generated-sources/oal/*.

@wu-sheng
Copy link
Copy Markdown
Member Author

wu-sheng commented Dec 6, 2018

@liuhaoyang The repository structure has changed. OAL-tool has been integrated.

@wu-sheng wu-sheng added this to the 6.0.0-beta milestone Dec 6, 2018
@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. backend OAP backend related. feature New feature labels Dec 6, 2018
Copy link
Copy Markdown
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,This is a very meaningful refactoring. And I compiled in my local env, It feels good to use.

Run `./mvnw compile` or `./mvnw package`, the generated codes of the oal script are in `oap-server/generate-tool/target/generated-sources/oal/*`.

## Write and recompile
You could change the `official_analysis.oal` script, then recompile codes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding the same we only recommend you to do this when you plan to build your own UI based on the customization analysis core. thing here? :-D

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember I used to put these words somewhere else? If you think we should put same in here. Feel free to add.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaredTan95 I am merging, if you want to add this, send another PR:)

Copy link
Copy Markdown
Member

@liuhaoyang liuhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 40eb651 into master Dec 7, 2018
@wu-sheng wu-sheng deleted the oal-tool-movein branch December 7, 2018 01:32
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.3%) to 14.314% when pulling 870c2dc on oal-tool-movein into c141376 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants