Merged
Conversation
xrmx
reviewed
Aug 23, 2024
xrmx
reviewed
Aug 26, 2024
Contributor
Author
|
@xrmx I'm not sure if I should make any changes related to these two comments #110 (comment) and #110 (comment) or if we should hold this PR until the next release. Let me know what you would like to do! |
Member
|
Will merge the PR after a release where the instructions will work. Thanks!
Il gio 29 ago 2024, 19:39 Colleen McGinnis ***@***.***> ha
scritto:
… @xrmx <https://github.com/xrmx> I'm not sure if I should make any changes
related to these two comments #110 (comment)
<#110 (comment)>
and #110 (comment)
<#110 (comment)>
*or* if we should hold this PR until the next release. Let me know what
you would like to do!
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADFBBIIE65COVABC24ZFTZT5MGNAVCNFSM6AAAAABM6KYQI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJYGQ3TAMJUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
xrmx
reviewed
Sep 3, 2024
xrmx
reviewed
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Builds out minimal viable docs. At a minimum, distribution docs should answer all of the following questions:
The initial commit includes the overall structure, but there is some information that is missing or needs to be validated. I've left code comments with questions to be answered throughout the files.
Read more about what needs to be included in these docs in Elastic Distributions of OpenTelemetry (Mini docs style guide) (internal doc).
To do
Related issues
Closes https://github.com/elastic/obs-docs-team/issues/241