Build docker image for OTel Kubernetes operator#132
Merged
Conversation
Add in the release workflow a job for building a Docker image for the kubernetes operator. The image is called elastic-otel-python-operator in case we need to build a docker image for another use case because the path where stuff is installed is specific for the operator.
When running in the k8s operator loading of an instrumentor may fail because the environment in which python extensions are built does not match the one from the running container. There are at least two cases: - different python version - different kind of wheels, e.g. manylinux vs musllinux To avoid the distro loading to fail catch ImportError here, that is the kind of exception we see when loading shared objects or cython extensions fails.
xrmx
changed the title
reakaleek
approved these changes
Sep 24, 2024
v1v
reviewed
Sep 24, 2024
v1v
reviewed
Sep 24, 2024
v1v
approved these changes
Sep 24, 2024
Member
v1v
left a comment
v1v
left a comment
There was a problem hiding this comment.
LGTM, I need to create the GH secrets, so bear with me please
xrmx
commented
Sep 24, 2024
Member
|
GH secrets have been created now |
xrmx
commented
Sep 24, 2024
trentm
approved these changes
Sep 24, 2024
And tags the images with edge instead of prefixing test-
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR introduces the build of a docker image (based on chainguard) that can be used with the opentelemetry kubernetes operator.
This also introduces a change of behavior when loading the instrumentors to cover this use case.
When running in the k8s operator loading of an instrumentor may fail because the environment in which python extensions are built does not match the one from the running container.
There are at least two cases:
To avoid the distro loading to fail catch ImportError here, that is the kind of exception we see when loading shared objects or cython extensions fails.
Related issues
Refs #82