Skip to content

[AWS] [CloudWatch] Improve description to highlight lastSync option#14733

Merged
Kavindu-Dodan merged 2 commits intoelastic:mainfrom
Kavindu-Dodan:chore/document-cloudwatch-lastsync-configuration
Jul 30, 2025
Merged

[AWS] [CloudWatch] Improve description to highlight lastSync option#14733
Kavindu-Dodan merged 2 commits intoelastic:mainfrom
Kavindu-Dodan:chore/document-cloudwatch-lastsync-configuration

Conversation

@Kavindu-Dodan
Copy link
Copy Markdown
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jul 29, 2025

Proposed commit message

Improve the description of start_position field with lastSync configuration option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Related elastic/beats#43251

Screenshots

image

@Kavindu-Dodan Kavindu-Dodan requested review from a team as code owners July 29, 2025 21:12
@Kavindu-Dodan Kavindu-Dodan added the enhancement New feature or request label Jul 29, 2025
@Kavindu-Dodan Kavindu-Dodan self-assigned this Jul 29, 2025
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/document-cloudwatch-lastsync-configuration branch 3 times, most recently from 5fa8e79 to bcf7f20 Compare July 29, 2025 21:18
@Kavindu-Dodan Kavindu-Dodan changed the title [AWS] [CloudWatch] Improve description to highlight lastSync [AWS] [CloudWatch] Improve description to highlight lastSync option Jul 29, 2025
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/document-cloudwatch-lastsync-configuration branch 2 times, most recently from 228082d to 78f12db Compare July 29, 2025 21:32
default: beginning
show_user: true
description: Allows user to specify if this input should read log files from the beginning or from the end.
description: Specify if the input should start reading logs from from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Specify if the input should start reading logs from from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before).
description: Specify if the input should start reading logs from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before).

(throughout)

Also consider s/if/whether/.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will fix this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this with - 91156f0 :)

@Kavindu-Dodan Kavindu-Dodan requested a review from efd6 July 29, 2025 21:55
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSI files LGTM

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Jul 29, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewkroh andrewkroh added Integration:aws_mq Amazon MQ Integration:aws AWS Integration:aws_bedrock Amazon Bedrock Integration:aws_logs Custom AWS Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 30, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

# Conflicts:
#	packages/aws/changelog.yml
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/document-cloudwatch-lastsync-configuration branch from 91156f0 to dd7ed62 Compare July 30, 2025 13:31
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @Kavindu-Dodan

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
Image 66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@Kavindu-Dodan Kavindu-Dodan merged commit 279466b into elastic:main Jul 30, 2025
8 of 9 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws - 3.13.4 containing this change is available at https://epr.elastic.co/package/aws/3.13.4/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws_bedrock - 1.2.3 containing this change is available at https://epr.elastic.co/package/aws_bedrock/1.2.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws_logs - 1.8.2 containing this change is available at https://epr.elastic.co/package/aws_logs/1.8.2/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws_mq - 0.9.1 containing this change is available at https://epr.elastic.co/package/aws_mq/0.9.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws_bedrock Amazon Bedrock Integration:aws_logs Custom AWS Logs Integration:aws_mq Amazon MQ Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants