Skip to content

[aws] Fix s3access ingest pipeline#17748

Merged
kaiyan-sheng merged 4 commits intomainfrom
s3_access
Mar 16, 2026
Merged

[aws] Fix s3access ingest pipeline#17748
kaiyan-sheng merged 4 commits intomainfrom
s3_access

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Mar 11, 2026

Proposed commit message

This PR fixes the s3access data stream ingest pipeline by:

  1. Host header with port: Extended S3ID pattern to allow : so host headers like bucket.s3.region.amazonaws.com:80 are matched.

  2. Trailing aclrequired field: Introduced S3ACLREQUIRED pattern [a-zA-Z0-9_-]+ and use it for the last optional field so values such as us-east-1 (and other hyphenated tokens) are parsed instead of failing the grok.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Sample log is already added and elastic-package test pipeline -d s3access --generate is used to update the expected.json file.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 11, 2026 04:25
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 11, 2026
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners March 11, 2026 04:28
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Mar 11, 2026

🚀 Benchmarks report

Package aws 👍(14) 💚(6) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vpcflow 7874.02 5586.59 -2287.43 (-29.05%) 💔
cloudwatch_logs 1e+06 500000 -500000 (-50%) 💔

To see the full report comment with /test benchmark fullreport

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Mar 15, 2026
@kaiyan-sheng kaiyan-sheng enabled auto-merge (squash) March 16, 2026 05:13
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kaiyan-sheng

@kaiyan-sheng kaiyan-sheng merged commit 2a491c1 into main Mar 16, 2026
10 checks passed
@kaiyan-sheng kaiyan-sheng deleted the s3_access branch March 16, 2026 05:50
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws - 6.3.2 containing this change is available at https://epr.elastic.co/package/aws/6.3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants