Skip to content

Move RDS lightweight module config into integration#3467

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:aws_rds
Jun 6, 2022
Merged

Move RDS lightweight module config into integration#3467
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:aws_rds

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Jun 3, 2022

What does this PR do?

This PR is to move lightweight module configuration from metricbeat into integrations. Also this PR adds collection to all RDS metrics to cover MSSQL metrics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 3, 2022 16:15
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 3, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jun 3, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-03T16:17:23.605+0000

  • Duration: 31 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.893
Classes 91.667% (11/12) 👎 -4.893
Methods 82.439% (169/205) 👎 -6.423
Lines 92.673% (2087/2252) 👍 2.891
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaiyan-sheng kaiyan-sheng merged commit 7f563af into elastic:main Jun 6, 2022
@kaiyan-sheng kaiyan-sheng deleted the aws_rds branch June 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants