Skip to content

Fix misspelling of Log Stream Prefix variable in manifest for aws-clo…#3610

Merged
francescayeye merged 3 commits intoelastic:mainfrom
francescayeye:3608-aws-logs-custom-integration-log_stream_prefix-key-with-a-typo
Jun 30, 2022
Merged

Fix misspelling of Log Stream Prefix variable in manifest for aws-clo…#3610
francescayeye merged 3 commits intoelastic:mainfrom
francescayeye:3608-aws-logs-custom-integration-log_stream_prefix-key-with-a-typo

Conversation

@francescayeye
Copy link
Copy Markdown

…udwatch input

Bug

What does this PR do?

Fix a type in manifest of aws integrations for cloudwatch logs input (log_stream_prefix vs log_streams_prefix)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #3608

Screenshots

@francescayeye francescayeye requested a review from a team as a code owner June 28, 2022 03:13
@francescayeye francescayeye self-assigned this Jun 28, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T03:49:56.128+0000

  • Duration: 36 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 334
Skipped 0
Total 334

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.932
Classes 91.667% (11/12) 👎 -4.932
Methods 82.464% (174/211) 👎 -6.398
Lines 92.673% (2087/2252) 👍 2.726
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

@girodav girodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nugroho-exp
Copy link
Copy Markdown

@aspacca Shouldn't the version of the aws_logs package be increased as well?

@francescayeye
Copy link
Copy Markdown
Author

@nugroho-exp good catch! thanks

@francescayeye francescayeye merged commit 06bc9cd into elastic:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS Logs Custom integration - log_stream_prefix key with a typo

4 participants