[AWS] Update sample_event.json for kinesis data stream#3874
Merged
kaiyan-sheng merged 3 commits intoelastic:mainfrom Jul 28, 2022
kaiyan-sheng:aws_kinesis
Merged
[AWS] Update sample_event.json for kinesis data stream#3874kaiyan-sheng merged 3 commits intoelastic:mainfrom kaiyan-sheng:aws_kinesis
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:aws_kinesis
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kaiyan-sheng
commented
Jul 28, 2022
| footnote: 'Examples: If Metricbeat is running on an EC2 host and fetches data from its host, the cloud info contains the data about this machine. If Metricbeat runs on a remote machine outside the cloud and fetches data from a service running in the cloud, the field contains cloud data from the machine the service is running on.' | ||
| type: group | ||
| fields: | ||
| - name: account.id |
Author
There was a problem hiding this comment.
These fields are all from ECS, that's why I'm removing them into the ecs.yml file. I wonder if we should have a meta PR for doing the same thing for other data streams.
tommyers-elastic
approved these changes
Jul 28, 2022
Contributor
tommyers-elastic
left a comment
tommyers-elastic
left a comment
There was a problem hiding this comment.
thanks for this ! sounds like removing ECS fields from agent.yml across all integrations is a good idea, but don't worry about it right now. it doesn't have much impact AFAICT. i'll put something on the backlog that we can think about later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to update the sample_event.json file for kinesis data stream.
Checklist
changelog.ymlfile.