[AWS][Lambda] Add metric type to lambda fields#6045
Merged
constanca-m merged 3 commits intoelastic:mainfrom May 17, 2023
Merged
[AWS][Lambda] Add metric type to lambda fields#6045constanca-m merged 3 commits intoelastic:mainfrom
constanca-m merged 3 commits intoelastic:mainfrom
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
5 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
tetianakravchenko
approved these changes
May 2, 2023
| @@ -20,43 +20,56 @@ | |||
| type: group | |||
| fields: | |||
| - name: Invocations.avg | |||
Contributor
There was a problem hiding this comment.
@elastic/obs-cloud-monitoring just wondering why all datastreams are missing unit configuration, somehow I thought it is important to add it
There was a problem hiding this comment.
We should definitely add the unit field.
kaiyan-sheng
approved these changes
May 16, 2023
Contributor
Author
|
/test |
|
Package aws - 1.36.0 containing this change is available at https://epr.elastic.co/search?package=aws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add field metric type to the Lambda data stream for TSDB support.
Details
All metrics used in this data stream are computed based on aggregations: average, max and sum. Even though max and sum might seem as counters, these are computed at a given moment in time and are not cumulative values over time. All metrics go up and down and for that, all of them are gauges.
Checklist
changelog.ymlfile.How to test this PR locally
Refer to #5970
Related issues