Change s3 input name to aws-s3#631
Change s3 input name to aws-s3#631kaiyan-sheng merged 5 commits intoelastic:masterfrom kaiyan-sheng:fix_s3
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
@mtojek This only works with filebeat 7.12 so should I wait till after 7.12 get released before merging this? TIA! |
mtojek
left a comment
There was a problem hiding this comment.
The 7.12 stack has been merged, feel free to rebase this branch against master.
BTW you can think also about system tests for the AWS integration as it's also available (not necessary as part of this PR).
|
@mtojek Yeah I will create a separate PR (hopefully soon) for system tests!! Thanks! |
|
The build is failing due to this: elastic/beats#24198 . If it's not an urgent issue I would wait for the correct Docker images. |
mtojek
left a comment
There was a problem hiding this comment.
If the CI is happy, I'm happy too :)
What does this PR do?
NOTE: This PR should wait till 7.12.0 release before merging.
This PR is to change
s3input name toaws-s3in order to match the renaming we did in Filebeat.Since the PR in Beats merged for 7.12, this only works when testing with:
Checklist