Skip to content

Change s3 input name to aws-s3#631

Merged
kaiyan-sheng merged 5 commits intoelastic:masterfrom
kaiyan-sheng:fix_s3
Apr 28, 2021
Merged

Change s3 input name to aws-s3#631
kaiyan-sheng merged 5 commits intoelastic:masterfrom
kaiyan-sheng:fix_s3

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Feb 2, 2021

What does this PR do?

NOTE: This PR should wait till 7.12.0 release before merging.

This PR is to change s3 input name to aws-s3 in order to match the renaming we did in Filebeat.
Since the PR in Beats merged for 7.12, this only works when testing with:

elastic-package stack up --version 7.12.0-SNAPSHOT -v -d

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

@kaiyan-sheng kaiyan-sheng self-assigned this Feb 2, 2021
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Feb 2, 2021
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-04-28T22:28:18.513+0000

  • Duration: 33 min 38 sec

  • Commit: 8b2a16e

Test stats 🧪

Test Results
Failed 0
Passed 1966
Skipped 3
Total 1969

Trends 🧪

Image of Build Times

Image of Tests

@kaiyan-sheng
Copy link
Copy Markdown
Author

@mtojek This only works with filebeat 7.12 so should I wait till after 7.12 get released before merging this? TIA!

@kaiyan-sheng kaiyan-sheng mentioned this pull request Feb 2, 2021
8 tasks
@kaiyan-sheng kaiyan-sheng requested a review from mtojek February 3, 2021 15:13
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 7.12 stack has been merged, feel free to rebase this branch against master.

BTW you can think also about system tests for the AWS integration as it's also available (not necessary as part of this PR).

@kaiyan-sheng
Copy link
Copy Markdown
Author

@mtojek Yeah I will create a separate PR (hopefully soon) for system tests!! Thanks!

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Feb 24, 2021

The build is failing due to this: elastic/beats#24198 . If it's not an urgent issue I would wait for the correct Docker images.

@kaiyan-sheng kaiyan-sheng requested a review from mtojek April 28, 2021 21:25
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI is happy, I'm happy too :)

@kaiyan-sheng kaiyan-sheng merged commit 40bf295 into elastic:master Apr 28, 2021
@kaiyan-sheng kaiyan-sheng deleted the fix_s3 branch April 28, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants