Skip to content

[Azure] Integration settings UI for sanitization#6357

Merged
lucian-ioan merged 12 commits intoelastic:mainfrom
lucian-ioan:azure_sanitize_ui
Jun 19, 2023
Merged

[Azure] Integration settings UI for sanitization#6357
lucian-ioan merged 12 commits intoelastic:mainfrom
lucian-ioan:azure_sanitize_ui

Conversation

@lucian-ioan
Copy link
Copy Markdown
Contributor

@lucian-ioan lucian-ioan commented May 29, 2023

What does this PR do?

Adds integration settings UI for elastic/beats#34874.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T05:37:44.938+0000

  • Duration: 14 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@lucian-ioan lucian-ioan self-assigned this May 29, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -10.417
Lines 84.935% (2802/3299) 👎 -15.065
Conditionals 100.0% (0/0) 💚

Comment on lines +47 to +48
title: Sanitizes New Lines
description: Sanitizes New Lines
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expand the description, explaining what it does and in which cases this is required. The same applies to sanitize_singlequotes the option.

Another option is keep this description shorter and add a section in the integration docs.

@lucian-ioan lucian-ioan marked this pull request as ready for review June 17, 2023 15:02
@lucian-ioan lucian-ioan requested a review from a team as a code owner June 17, 2023 15:02
@lucian-ioan lucian-ioan requested review from gpop63 and zmoog June 17, 2023 15:03
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a couple of suggestions on the docs.

Malformed logs can be indentified by:
- Presence of a records array in the message field, indicating a failure to unmarshal the byte slice.
- Existence of an error.message field containing the text "Received invalid JSON from the Azure Cloud platform. Unable to parse the source log message."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, besides the data streams used for the logs collection, the affected log categories are App Services, and Azure Functions logs.

The Native Azure Integration sends all logs to the platform or Spring Cloud logs data stream; that's why the ingest pipelines in these data streams handle these kinds if errors.

lucian-ioan and others added 2 commits June 19, 2023 08:16
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @lucian-ioan

@lucian-ioan lucian-ioan merged commit 5536535 into elastic:main Jun 19, 2023
@elasticmachine
Copy link
Copy Markdown

Package azure - 1.5.20 containing this change is available at https://epr.elastic.co/search?package=azure

@lucian-ioan lucian-ioan deleted the azure_sanitize_ui branch February 6, 2024 14:49
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants