Skip to content

[AWS][cloudwatch_metrics] Use object metric type for the cloudwatch metrics#7327

Merged
tetianakravchenko merged 2 commits intoelastic:mainfrom
tetianakravchenko:aws-cloudwatch-revert-metric-definition
Aug 10, 2023
Merged

[AWS][cloudwatch_metrics] Use object metric type for the cloudwatch metrics#7327
tetianakravchenko merged 2 commits intoelastic:mainfrom
tetianakravchenko:aws-cloudwatch-revert-metric-definition

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

What does this PR do?

In this previous PR - was mentioned that the expected field definition is:

type: object
object_type: double
object_type_mapping_type: "*"

As was mentioned in this comment defining type: double is not equal to the above, due to some differences in the generated dynamic_template. So was decided to switch back to the previous format

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 9, 2023 12:50
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-09T12:51:54.661+0000

  • Duration: 60 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 85.953% (257/299)
Lines 86.011% (7501/8721)
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit 2236361 into elastic:main Aug 10, 2023
@elasticmachine
Copy link
Copy Markdown

Package aws - 1.51.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants