handle both clientIp and clientIP in azure app gateway#7995
Merged
Conversation
🌐 Coverage report
|
3315897 to
3540111
Compare
3540111 to
5436a00
Compare
zmoog
approved these changes
Sep 27, 2023
Contributor
zmoog
left a comment
There was a problem hiding this comment.
LGTM!
We only need to bump the version and add a changelog, and we're ready to go!
|
Package azure - 1.5.33 containing this change is available at https://epr.elastic.co/search?package=azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There appears to be cases where Azure Application Gateway provides the client IP as
json.properties.clientIP, and others where it provides it asjson.properties.clientIp.We currently only handle the former to rename the field into
source.ip.integrations/packages/azure/data_stream/application_gateway/elasticsearch/ingest_pipeline/default.yml
Lines 56 to 59 in 6e13a10
This change ensures a
clientIpis first renamed toclientIP, so it can then becomesource.ip.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
This is unit tested.
Related issues
Screenshots