aws: fix query range calculation for GuardDuty datastream#8882
Merged
efd6 merged 1 commit intoelastic:mainfrom Jan 16, 2024
Merged
aws: fix query range calculation for GuardDuty datastream#8882efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
efd6
added
bug
The calculations for findingCriteria.criterion.updatedAt.*Than included a time truncation with the resolution of an hour. This has the effect that if there was no successful execution of the last_execution_datetime template the greaterThan and lessThan values would be equal 1 in hour/initial_interval times, resulting in spurious requests that required satisfaction of a null set. The truncation also prevents progession of the criteria for 1 - (1 in hour/initial_interval) HTTPJSON periodic request cycles.
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Package aws - 2.11.3 containing this change is available at https://epr.elastic.co/search?package=aws |
narph
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The calculations for
findingCriteria.criterion.updatedAt.*Thanincluded a time truncation with the resolution of an hour. This has the effect that if there was no successful execution of thelast_execution_datetime templatethegreaterThanandlessThanvalues would be equal 1 in hour/initial_interval times, resulting in spurious requests that required satisfaction of a null set. The truncation also prevents progression of the criteria for 1 - (1 in hour/initial_interval) HTTPJSON periodic request cycles.Not marking as closing the issue as I think there are still problems with the template evaluation that are not currently diagnosable with HTTPJSON's existing template logging (will be able to look at this when v8.11 is more prevalent ).
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots