Skip to content

Native support for additional Type Converters#353

Merged
erikwrede merged 15 commits intographql-python:masterfrom
erikwrede:typeconverters
Jul 15, 2022
Merged

Native support for additional Type Converters#353
erikwrede merged 15 commits intographql-python:masterfrom
erikwrede:typeconverters

Conversation

@erikwrede
Copy link
Copy Markdown
Member

@erikwrede erikwrede commented Jun 9, 2022

See corresponding discussion #345
Fixes #336

Co-authored-by: Viktor Pegy <xtpvxt@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 9, 2022

Codecov Report

❌ Patch coverage is 96.72131% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.37%. Comparing base (f16d434) to head (195b29f).
⚠️ Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
graphene_sqlalchemy/converter.py 95.91% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   96.39%   96.37%   -0.02%     
==========================================
  Files           9        9              
  Lines         721      773      +52     
==========================================
+ Hits          695      745      +50     
- Misses         26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…rs instead of String.

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
erikwrede added 3 commits June 9, 2022 16:42
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
….UUID instead of graphene.String

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
….key instead of Column.name, see graphql-python#330

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
erikwrede added 7 commits June 9, 2022 17:41
Co-authored-by: Nicolas Delaby <nicolas.delaby@infarm.com>
Co-authored-by: davidcim <david@cimaware.com>

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
…valent type names (in most cases)

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
@erikwrede erikwrede merged commit a702569 into graphql-python:master Jul 15, 2022
@erikwrede erikwrede mentioned this pull request Nov 29, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No UUIDType support

3 participants