Skip to content

Add param for output steam #24

Merged
mgedmin merged 2 commits intomgedmin:masterfrom
d-sun-d:master
Jan 25, 2016
Merged

Add param for output steam #24
mgedmin merged 2 commits intomgedmin:masterfrom
d-sun-d:master

Conversation

@d-sun-d
Copy link
Copy Markdown

@d-sun-d d-sun-d commented Dec 22, 2015

Now user can specify uotput stream.

I used lib with this modification in case where debug cann't be in sys.stdout

@mgedmin
Copy link
Copy Markdown
Owner

mgedmin commented Dec 22, 2015

Thank you for the pull request!

I think output_stream is a bit too long. Let's call it file, like the Python 3 built-in print(..., file=sys.stdout) function.

The Travis CI build failure is caused by PEP-8 warnings:

./objgraph.py:172:80: E501 line too long (94 > 79 characters)
./objgraph.py:201:80: E501 line too long (84 > 79 characters)
./objgraph.py:242:80: E501 line too long (85 > 79 characters)
make: *** [lint] Error 1

and renaming output_stream to file should fix two of them. The third long line will need some wrapping.

@d-sun-d
Copy link
Copy Markdown
Author

d-sun-d commented Jan 25, 2016

fix name and split big line

mgedmin added a commit that referenced this pull request Jan 25, 2016
Add param for output steam
@mgedmin mgedmin merged commit 4f35b38 into mgedmin:master Jan 25, 2016
@mgedmin
Copy link
Copy Markdown
Owner

mgedmin commented Jan 25, 2016

Thank you!

mgedmin added a commit that referenced this pull request Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants