Applying code action 'Sort imports' hangs indefinitely

[soapergem]

Environment data

• VS Code version: 1.47.3
• Extension version (available under the Extensions sidebar): v2020.7.96456
• OS and version: Ubuntu 20.04
• Python version: 3.8.3 (installed by pyenv)
• Type of virtual environment used: pyenv-virtualenv
• Relevant/affected Python packages and their versions: XXX
• Relevant/affected Python-related VS Code extensions and their versions: XXX
• Value of the python.languageServer setting: doesn't seem to matter; I have tried Jedi, Microsoft, Pylance, and None
• isort version: 4.3.21

Expected behaviour

When I hit save on a Python file, I expect it to quickly/automatically sort my imports

Actual behaviour

It pops up a box much like this one:

Saving 'main.py': Applying code action 'Sort imports'.

And that box never goes away. It hangs indefinitely. Obviously it never actually sorts my imports either, nor does it proceed to linting / auto-formatting. It just gets stuck.

Steps to reproduce:

1. pip install black pylint isort autoflake
2. Copy my settings.json file
3. Save a Python file

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

> ~/.pyenv/versions/myproject/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/src/myproject/home
> ~/.pyenv/versions/myproject/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/src/myproject/home

[bguisard]

@soapergem this seem similar to #12949

I've been having these issues for a long time. and they seem to be fixed on the insiders version.

[bguisard]

Actually they are not solved on the insiders version. It intermittently stopped happening after I started using the insiders version, but I am still experiencing the problem.

[brgirgis]

I have been having this exact problem since the recent version. Starting a new session everything works fine. After some time, not sure exactly what happens to trigger it or exact time frame, but at some point I try to save and all I get is a spinning circle as shown below.

It never finishes and the file does not get saved at all.

[brgirgis]

Looking at .vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\sortImports.py, this code looks fishy!

# Work around stdin buffering issues on windows (https://bugs.python.org/issue40540)
# caused in part by isort seeking within the stdin stream by replacing the
# stream with something which is definitely seekable.
try:
    # python 3
    stdin = sys.stdin.buffer
except AttributeError:
    # python 2
    stdin = sys.stdin

sys.stdin = io.BytesIO(stdin.read())
# End workaround

[brgirgis]

I disabled this block of code. I'm using python 3.7.4, VSCode 1.47.3 and ms-python.python v2020.7.96456 on Windows 10. I will let you know if this issues is still reproducible without this block of code.

[brgirgis]

Disabling this code block does not stop this issue.

[vishal16babu]

I am also facing the same issue. I am using vscode 1.47.3. OS Ubuntu 20.04.

[andrewhead]

To add another data point, I'm experiencing this problem as well, with VSCode version on Mac:

Version: 1.47.3
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:08:29.692Z (2 wks ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.5.0

I find it is still possible to format and save the file without sorting the imports by running these two commands from the command palette, which don't seem to invoke import sorting:

• Format Document
• File: Save without Formatting

which tides me over for now. Though it would be cool to know if there's a potential fix to the hanging "Sort imports", as it's awesome to have the editor manage them automatically :-)

[vishal16babu]

This issue got fixed by installing isort in my virtual environment
pip install isort
Usually vscode asks if it can install black or flake8 or any linter which is part of your settings but in case of isort it just hangs without showing any such message.

[soapergem]

This issue got fixed by installing isort in my virtual environment

No it didn't. That does not fix the issue. In fact, installing isort in your virtual environment is the first step that I posted in the "Steps to Reproduce" above.