Text changes for completion CodeAction are affected by the completion

• VSCode Version: Code - Insiders 1.19.0-insider (cd906f8, 2017-12-07T06:14:22.977Z)
• OS Version: Linux x64 4.4.0-21-generic
• Extensions: none

---

Steps to Reproduce:

1. Create b.ts containing:

export const foo = 0;
export const bar = 1;

2. Create a.ts containing:

; import { foo } from "./b";

3. Go to the start of the line, type ba, and accept the completion.
4. You get bar; import { fo, baro } from "./b";
   (expected bar; import { foo, bar } from "./b";)

@mjbvz We were talking about this at the meeting today.

[mjbvz]

@jrieken I switched the TS auto import completions to use additionalTextEdits but still see this issue. Here's the text changes we get from TS:

[Trace  - 2:07:10 PM] Response received: completionEntryDetails (47). Request took 7 ms. Success: true 
Result: [
    {
       ...
        "codeActions": [
            {
                "description": "Add 'bar' to existing import declaration from \"./b\".",
                "changes": [
                    {
                        "fileName": "/Users/matb/projects/san/a.ts",
                        "textChanges": [
                            {
                                "start": {
                                    "line": 1,
                                    "offset": 17
                                },
                                "end": {
                                    "line": 1,
                                    "offset": 17
                                },
                                "newText": ", bar"
                            }
                        ]
                    }
                ]
            }
        ]
    }
]

We could try applying all the changes with additionalTextEdits or shifting down the TS text edits. Any suggestions?

[jrieken]

The problem is that the main edit runs via the snippet controller and the rest as normal text edits. When both occur on the same line no adjustment happens...

[jrieken]

@mjbvz The behaviour is kind of expected when using the command for the additional edits... That's because we have no clue what's happening... I have added a unit test for the additional edits scenarios and it works for me. Did you try this by any chance after making the changes in #39944?