fix: include additional toggles in find input arrow key navigation#306559
Merged
meganrogge merged 1 commit intomicrosoft:mainfrom Apr 2, 2026
Merged
Conversation
bhavyaus
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix (accessibility)
What is the current behavior?
When using arrow keys to navigate between toggle buttons in the find input (case sensitive, whole words, regex), only the three standard toggles are reachable. Additional toggles — such as the notebook find filter button (funnel icon) — are excluded from keyboard navigation. This means users who rely on keyboard navigation cannot reach these controls using arrow keys.
Fixes #207765
What is the new behavior?
Arrow key navigation now includes all toggles in the find input:
FindInputbase class: The staticindexesarray (hardcoded to[caseSensitive, wholeWords, regex]) is replaced with a dynamic `getToggleDomNodes()` method that returns DOM nodes for all standard toggles plus any `additionalToggles`.NotebookFindInputsubclass: Overrides `getToggleDomNodes()` to also include the filter button container, so the notebook find widget's funnel icon is reachable via arrow keys.The `getToggleDomNodes()` method is `protected`, allowing any subclass of `FindInput` to extend the set of keyboard-navigable toggles.
Additional context
The issue was identified by @andreamah, who pointed to the exact location in `findInput.ts` where the arrow key indexes were hardcoded. The fix is minimal and scoped: