Conversation
Greptile SummaryThis PR moves
Confidence Score: 4/5Mergeable for CI hardening purposes, but the stated goal of making pydantic optional for end-users is not fully achieved in this PR A P1 finding exists: pydantic remains a required transitive dependency through reflex-base's pyproject.toml, meaning installing 'reflex' without '[db]' still installs pydantic. The code-level guards (find_spec checks) are in place in reflex-base, so the CI test is meaningful, but the package metadata is incomplete. Score is 4 because this should be addressed to fully realize the intent. pyproject.toml (the db optional extra's pydantic entry is redundant until packages/reflex-base/pyproject.toml is also updated to make pydantic optional) Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv sync - full env with all deps] --> B
B["uv pip uninstall\npydantic alembic sqlalchemy sqlmodel"] --> C
C["uv run --no-sync pytest tests/units"] -->|pass| D[uv sync - restore full env]
C -->|fail| E[❌ CI Fails]
D --> F[uv run pytest tests/units]
F --> G["uv run pytest tests/units\nwith redis"]
G --> H["uv run pytest tests/units\nwith redis + OPLOCK"]
H --> I[uv run coverage html]
style B fill:#ffe4b5
style C fill:#ffe4b5
style E fill:#f66,color:#fff
|
No description provided.