Use register_renamed instead of register_removed for uplifted lints#7056
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 9, 2021
Merged
Use register_renamed instead of register_removed for uplifted lints#7056bors merged 1 commit intorust-lang:masterfrom
register_renamed instead of register_removed for uplifted lints#7056bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
commented
Apr 9, 2021
| /// **What it does:** Nothing. This lint has been deprecated. | ||
| /// | ||
| /// **Deprecation reason:** This lint has been uplifted to rustc and is now called | ||
| /// `panic_fmt`. |
Member
Author
There was a problem hiding this comment.
This caught a bug - the lint is called non_fmt_panic now.
flip1995
approved these changes
Apr 9, 2021
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
To fix CI failure search for the removed lints in CHANGELOG.md and remove the brackets [] around them.
In theory we have a separate test file for renamed lints: rename.rs. But no one updated this file in a while, so keeping it in deprecated.rs for now seems fine. I'll open an issue to update the rename.rs test.
This still applies the lint, and also adds a structured suggestion to rename it.
Member
Author
|
Thanks, done. |
Member
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 012f9d4 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still applies the lint, and also adds a structured suggestion to
rename it.
changelog: Use
register_renamedinstead ofregister_removedfor lints uplifted to rustc