Skip to content

chore: refactor Updatecli gha workflow & fix zizmor config file#1069

Merged
olblak merged 7 commits intoupdatecli:mainfrom
olblak:main
Mar 28, 2026
Merged

chore: refactor Updatecli gha workflow & fix zizmor config file#1069
olblak merged 7 commits intoupdatecli:mainfrom
olblak:main

Conversation

@olblak
Copy link
Copy Markdown
Member

@olblak olblak commented Mar 28, 2026

Description

Reorganise Updatecli workflow and labels to show meaningfull information on udash

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

olblak added 3 commits March 28, 2026 11:01
Signed-off-by: Olivier Vernin <me@olblak.com>
Signed-off-by: Olivier Vernin <me@olblak.com>
Signed-off-by: Olivier Vernin <me@olblak.com>
@olblak olblak changed the title choreL chore: refactor Updatecli gha workflow & fix zizmor config file Mar 28, 2026
@olblak olblak requested a review from Copilot March 28, 2026 10:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Updatecli configuration/workflows to change pipeline labeling/filtering, consolidate policy values, and adjust zizmor configuration.

Changes:

  • Migrate Updatecli policy values from updatecli/values.d/* files into updatecli-compose.yaml.
  • Rename Updatecli pipeline labels (e.g., monitoring:enabledmonitor:active) and update workflow label filters accordingly.
  • Add a new “release” Updatecli workflow and loosen zizmor rule configuration.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
updatecli/values.d/npm.yaml Removes NPM policy values file (intended move to compose inline values).
updatecli/values.d/nodejs.yaml Removes Node.js policy values file (intended move to compose inline values).
updatecli/values.d/githubaction.yaml Removes GitHub Actions policy values file (previously included digest config).
updatecli/updatecli.d/updatecli.yaml Updates pipeline labels to new taxonomy (ecosystem, monitor, release).
updatecli-compose.yaml Refactors policies to use inline values blocks and adds pipeline labels in compose.
.github/zizmor.yaml Disables secrets-outside-env rule instead of using an allow-list.
.github/workflows/updatecli_update.yaml Updates label selector to monitor:active.
.github/workflows/updatecli_release.yaml Adds a new workflow intended for “release” labeled pipelines.
.github/workflows/updatecli.yaml Removes release trigger from the main Updatecli workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

olblak added 4 commits March 28, 2026 11:17
Signed-off-by: Olivier Vernin <me@olblak.com>
Signed-off-by: Olivier Vernin <me@olblak.com>
Signed-off-by: Olivier Vernin <me@olblak.com>
Signed-off-by: Olivier Vernin <me@olblak.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 2 to 6
name: Updatecli
on:
release:
workflow_dispatch:
schedule:
# Run at 12:00 every 14 days
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the on: release trigger means this repo will no longer run Updatecli automatically on GitHub Release events (and the new updatecli_release.yaml is not wired to release either). If Release events are still meant to drive updates, add an on: release trigger to the appropriate workflow (or document how repository_dispatch is fired from releases).

Copilot uses AI. Check for mistakes.
@olblak olblak merged commit f74d22d into updatecli:main Mar 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants