comments: fix memory leak when recycling tree items in comment panel#304666
Merged
alexr00 merged 5 commits intomicrosoft:mainfrom Mar 30, 2026
Merged
comments: fix memory leak when recycling tree items in comment panel#304666alexr00 merged 5 commits intomicrosoft:mainfrom
alexr00 merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses disposable leaks in the Comments view tree by adding disposeElement() to CommentNodeRenderer, aiming to clean up per-element resources when a tree template is recycled.
Changes:
- Implement
disposeElement()inCommentNodeRendererto dispose and clear template-associated disposables between element reuses.
xingsy97
changed the title
alexr00
approved these changes
Mar 30, 2026
bpasero
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CommentNodeRenderer.renderElement()pushes new disposables (DisposableStore, rendered markdown element, hover) intotemplateData.disposableson every call. When the tree recycles a template for a different element, these disposables accumulate because there is nodisposeElementmethod to clean them up between reuses. OnlydisposeTemplate(called on template destruction) disposes them.Fix
Add
disposeElement()that disposes and clears the per-element disposables array when a template is recycled, matching theIListRendererlifecycle contract.