Skip to content

Removing second to minute conversion as selected unit is in second#2420

Merged
v-jayakal merged 8 commits intoAzure:masterfrom
samikroy:master
Jul 2, 2021
Merged

Removing second to minute conversion as selected unit is in second#2420
v-jayakal merged 8 commits intoAzure:masterfrom
samikroy:master

Conversation

@samikroy
Copy link
Copy Markdown
Contributor

@samikroy samikroy commented Jun 7, 2021

Fixes #

Removing second to minute conversion as selected unit is in second

samikroy added 3 commits June 7, 2021 20:54
Removed second to minute conversion as the unit is set to 24, which indicates seconds.
Removing second to minute conversion (/60) as selected unit is second (unit : 24)
Comment thread Workbooks/WorkspaceUsage.json Outdated
@v-ampami
Copy link
Copy Markdown
Contributor

v-ampami commented Jun 8, 2021

Please update the workbook version in workbook metadata json.

@v-ampami
Copy link
Copy Markdown
Contributor

There are still locales in documentation links. Please remove all the locale("en-us", "en-gb") from documentation links.

@v-rucdu
Copy link
Copy Markdown
Contributor

v-rucdu commented Jun 15, 2021

@samikroy : Could you please resolve the merge conflicts.

Thanks!!!

@samikroy
Copy link
Copy Markdown
Contributor Author

samikroy commented Jun 16, 2021

@samikroy : Could you please resolve the merge conflicts.

Thanks!!!

Done, thank you.

@liatlishams - could you please help in merging.

Copy link
Copy Markdown
Contributor Author

@samikroy samikroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as commented.

@samikroy
Copy link
Copy Markdown
Contributor Author

@v-ampami , @liatlishams , @Amitbergman - Request your help to approve the workbook.

@v-jayakal v-jayakal merged commit 30a30db into Azure:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants