Short ref doesn't appear in CI builds

[Commenter25]

Verification

• I searched for similar bug reports (including closed issues) and found none was relevant.

What happened?

When checking the About or Firmware pages, if running a build from GitHub CI, there will be no short ref

What should happen instead?

There should be one

Reproduction steps

1. Download and install a release build
2. Go to the about page and see a commit reference next to short ref (for 1.13, this is 5f3acfad)
3. Download and install a CI build (this is the 1.13 commit)
4. Go to the about page and notice a distinct lack of a short ref

Version

v1.13.0

Companion app

Gadgetbridge v0.75.1

[jensonb]

I also noticed this issue as well when building myself. Where does the release build actually come from?

Either way, the git hash is retrieved during the following portion of the build:

InfiniTime/CMakeLists.txt

Lines 38 to 57 in 5f3acfa

	set(PROJECT_GIT_COMMIT_HASH "")
	execute_process(COMMAND git rev-parse --short HEAD
	WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
	OUTPUT_VARIABLE PROJECT_GIT_COMMIT_HASH
	RESULT_VARIABLE PROJECT_GIT_COMMIT_HASH_SUCCESS)
	string(STRIP "${PROJECT_GIT_COMMIT_HASH}" PROJECT_GIT_COMMIT_HASH)
	message("PROJECT_GIT_COMMIT_HASH_SUCCESS? " ${PROJECT_GIT_COMMIT_HASH_SUCCESS})
	message("")
	message("BUILD CONFIGURATION")
	message("-------------------")
	message(" * Mode : " ${CMAKE_BUILD_TYPE})
	message(" * Version : " ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH})
	message(" * Toolchain : " ${ARM_NONE_EABI_TOOLCHAIN_PATH})
	message(" * GitRef(S) : " ${PROJECT_GIT_COMMIT_HASH})
	message(" * NRF52 SDK : " ${NRF5_SDK_PATH})
	message(" * Target device : " ${TARGET_DEVICE})

https://github.com/InfiniTimeOrg/InfiniTime/actions/runs/5364794676/job/14523852337#step:4:55

the git command seems to be failing

[FintasticMan]

Seems that PR didn't actually fix the issue in CI.