Bug Description
When deploying standalone plugins, it looks like at the moment the .wordpress-org directories for them are actually deployed to WordPress.org, as part of the actual plugin. The files in that directory should only be deployed into the SVN repository's assets folder, which works as expected, but additionally the .wordpress-org directory is also added to the plugin itself. This is unnecessary and notably increases the plugin ZIP size, so it should be fixed.
I discovered this bug when doing a DRY_RUN for the Dominant Color Images plugin (see https://github.com/WordPress/performance/actions/runs/6425426416/job/17447991722#step:6:100).
After that I checked the existing standalone plugins and found the bug already present there too, see below:
Note: This is only a problem for the standalone plugins, not for the main Performance Lab plugin.
Solution
- We need to ensure that the
.wordpress-org directory for each standalone plugin is not deployed as part of the plugin itself (i.e. within the plugin's SVN trunk directory).
- While fixing that, we must however ensure that the files from the
.wordpress-org directory continue to be considered for the plugin's SVN assets directory.
- Since this bug is already in production for
webp-uploads and fetchpriority, and dominant-color-images, we should probably as part of the PR also bump the version of those plugins as a patch version increase, so that upon the next deployment the problem is fixed.
fetchpriority is no longer part of the repository, so we can ignore that part.
Bug Description
When deploying standalone plugins, it looks like at the moment the
.wordpress-orgdirectories for them are actually deployed to WordPress.org, as part of the actual plugin. The files in that directory should only be deployed into the SVN repository'sassetsfolder, which works as expected, but additionally the.wordpress-orgdirectory is also added to the plugin itself. This is unnecessary and notably increases the plugin ZIP size, so it should be fixed.I discovered this bug when doing a
DRY_RUNfor the Dominant Color Images plugin (see https://github.com/WordPress/performance/actions/runs/6425426416/job/17447991722#step:6:100).After that I checked the existing standalone plugins and found the bug already present there too, see below:
Note: This is only a problem for the standalone plugins, not for the main Performance Lab plugin.
Solution
.wordpress-orgdirectory for each standalone plugin is not deployed as part of the plugin itself (i.e. within the plugin's SVNtrunkdirectory)..wordpress-orgdirectory continue to be considered for the plugin's SVNassetsdirectory.webp-uploadsandfetchpriority, anddominant-color-images, we should probably as part of the PR also bump the version of those plugins as a patch version increase, so that upon the next deployment the problem is fixed.fetchpriorityis no longer part of the repository, so we can ignore that part.