Refresh feature branch with trunk#676
Merged
felixarntz merged 19 commits intofeature/creating-standalone-pluginsfrom Mar 16, 2023
Merged
Refresh feature branch with trunk#676felixarntz merged 19 commits intofeature/creating-standalone-pluginsfrom
felixarntz merged 19 commits intofeature/creating-standalone-pluginsfrom
Conversation
Add `wp-total` metric to default Server-Timing metrics
…nly-for-loading Ensure module `load.php` files really only load other code to prevent conflicts in standalone plugins
Fix problems with placing `object-cache.php` drop-in
felixarntz
added
[Type] Enhancement
felixarntz
requested review from
JustinyAhin,
adamsilverstein and
mitogh
as code owners
felixarntz
changed the base branch from
trunk
to
feature/creating-standalone-plugins
felixarntz
requested review from
manuelRod,
pbearne and
spacedmonkey
as code owners
Merged
3 tasks
mukeshpanchal27
approved these changes
Mar 16, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz, LGTM!
10upsimon
approved these changes
Mar 16, 2023
Contributor
10upsimon
left a comment
10upsimon
left a comment
There was a problem hiding this comment.
Approving as I've already approved the code that was merged to trunk, and the commit with changes (the only new code) LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR for #667 was intentionally merged into
trunk, so we should update our feature branch to get those changes as well since they are critical for the creating standalone plugins work.This PR is really just a merge commit, the code was already reviewed before. The only new code change here is 7ba9b77.
Relevant technical choices
load.phpfile since we shouldn't declare functions in the main file any longer.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.