Update the module constant#681
Merged
felixarntz merged 1 commit intofix/666-check-module-loadedfrom Mar 17, 2023
Merged
Conversation
mukeshpanchal27
added
[Type] Enhancement
mukeshpanchal27
requested review from
JustinyAhin and
felixarntz
as code owners
Merged
3 tasks
felixarntz
approved these changes
Mar 17, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Thanks, this is a solid and simple solution. Let's not merge this before we have merged #670 though. Or maybe, since we're still discussing on that PR and the change here is so small, you could add it to the other PR instead so that we only have to have one PR to review and merge - also since the two changes are so closely related.
Maybe my previous idea of splitting them didn't make so much sense after all 🙃
Member
|
@mukeshpanchal27 Actually never mind, I see you have the branch for #670 as target branch. In that case, we can of course go ahead and merge this one in there. I'll do that now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is followup work in which the
build-pluginscommand updates the constant value defined in #666.Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.