NIFI-15567 Streamline Component Authorizable Evaluation Methods#10871
Closed
exceptionfactory wants to merge 3 commits intoapache:mainfrom
Closed
NIFI-15567 Streamline Component Authorizable Evaluation Methods#10871exceptionfactory wants to merge 3 commits intoapache:mainfrom
exceptionfactory wants to merge 3 commits intoapache:mainfrom
Conversation
- Added AuthorizeComponentReference class with shared methods for evaluating authorized configuration operations and referenced Controller Services - Updated create and update operations for Components using shared methods
pvillard31
requested changes
Feb 8, 2026
pvillard31
reviewed
Feb 9, 2026
Contributor
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory. Looks good to go, left some minor comments.
|
|
||
| import java.util.Map; | ||
|
|
||
| public class AuthorizeComponentReference { |
Contributor
There was a problem hiding this comment.
Shouldn't it be final like its sibling AuthorizeControllerServiceReference?
| } | ||
| } | ||
| final ProcessorConfigDTO config = requestProcessor.getConfig(); | ||
| final Map<String, String> properties = config == null ? Map.of() : config.getProperties(); |
Contributor
There was a problem hiding this comment.
Noticed that you are using Map.of() here but Collections.emptyMap() in ProcessorResource. Better to be consistent, no?
| // authorize any parameter references | ||
| AuthorizeParameterReference.authorizeParameterReferences(properties, authorizer, authorizable.getParameterContext(), user); | ||
| AuthorizeParameterReference.authorizeParameterReferences(annotationData, authorizer, authorizable.getParameterContext(), user); | ||
| final Authorizable parameterContext = authorizable.getParameterContext(); |
Contributor
There was a problem hiding this comment.
Suggested change
| final Authorizable parameterContext = authorizable.getParameterContext(); | |
| final ParameterContext parameterContext = authorizable.getParameterContext(); |
Like in L610, no?
Contributor
Author
|
Thanks for the feedback on consistency items @pvillard31, I pushed an update with adjustments. |
pvillard31
approved these changes
Feb 9, 2026
yisun-anetac
pushed a commit
to Eng-Anetac/nifi
that referenced
this pull request
Apr 4, 2026
- Added AuthorizeComponentReference class with shared methods for evaluating authorized configuration operations and referenced Controller Services - Updated create and update operations for Components using shared methods This closes apache#10871. Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15567 Refactors and streamlines framework handling of
ComponentAuthorizablereferences for both create and update operations using a shared class.The new
AuthorizeComponentReferenceclass follows a pattern similar to classes for Controller Services and Parameter Providers, defining new methods for evaluating component restrictions and references in a single location. The unified approach removes duplicative try-finally handling for component creation, and supports reuse of similar evaluation for component updates.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation